fix: pr-bug-scan findings from #1409#1422
Open
buf0-bot[bot] wants to merge 1 commit intomainfrom
Open
Conversation
Fixed pty-connection passphrase wait gate: added 'disconnected' as terminal status (only after seeing a non-disconnected state) so cancel resolves; added waitTeardowns registry so dispose() actively u
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automated fix-PR from pr-bug-scan for parent #1409.
Fixer summary: Fixed pty-connection passphrase wait gate: added 'disconnected' as terminal status (only after seeing a non-disconnected state) so cancel resolves; added waitTeardowns registry so dispose() actively unsubscribes + resolves in-flight waits to prevent zustand listener/IIFE leaks.
Typecheck:
skippedFindings addressed
src/renderer/src/components/terminal-pane/pty-connection.ts— wait promise hangs forever if user cancels passphrase dialogsrc/renderer/src/components/terminal-pane/pty-connection.ts— store subscriber leaks when pane disposes during waitThis PR was generated by the
pr-bug-scanautomation and reviewed by an agent reviewer. Human approval required before merge.