fix(pet): drop stale GLB entries from hydrated custom pet list#1333
Open
AmethystLiang wants to merge 1 commit intoadd-a-pet-for-orcafrom
Open
fix(pet): drop stale GLB entries from hydrated custom pet list#1333AmethystLiang wants to merge 1 commit intoadd-a-pet-for-orcafrom
AmethystLiang wants to merge 1 commit intoadd-a-pet-for-orcafrom
Conversation
Pre-refactor persisted customPetModels may contain .glb entries that the image-based overlay can't render. Filter them on hydration so the pet menu doesn't show broken rows and petModelId can't resolve to one. Co-authored-by: Orca <help@stably.ai>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
customPetModelsmay contain.glbentries from when the pet overlay rendered 3D models via three.js.<img>tag, so a legacy entry appeared as a broken row in the pet menu and could resolve as the activepetModelId..glbfilenames out ofcustomPetModelsduring hydration and during thepetModelIdfallback lookup.Test plan
.glbcustom pet entry; verify it does not appear in the pet menu andpetModelIdfalls back todefault.Made with Orca 🐋