Skip to content

Upgrade npm to latest for OIDC trusted publishing#6

Merged
sambhav-aggarwal merged 1 commit into
mainfrom
fix/npm-oidc-version
May 3, 2026
Merged

Upgrade npm to latest for OIDC trusted publishing#6
sambhav-aggarwal merged 1 commit into
mainfrom
fix/npm-oidc-version

Conversation

@sambhav-aggarwal
Copy link
Copy Markdown
Member

Node 22 ships npm 10.x; OIDC trusted publishing needs npm >= 11.5. Bump 0.1.4.

Node 22.x ships with npm 10.x; npm's auto-OIDC trusted publishing flow
requires npm >= 11.5. Add 'npm install -g npm@latest' before npm ci so
the runner has a recent enough npm to perform the OIDC token exchange.
@sambhav-aggarwal sambhav-aggarwal merged commit 2b5d957 into main May 3, 2026
@sambhav-aggarwal sambhav-aggarwal deleted the fix/npm-oidc-version branch May 3, 2026 09:33
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: c64b5a93a6

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

with:
node-version: 22.x
cache: npm
- run: npm install -g npm@latest
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Pin npm version in publish workflow

Installing npm@latest makes release behavior non-deterministic and can break tag publishes as soon as npm ships a new major with changed defaults or Node engine requirements; this job runs on every v* tag, so a future npm release can fail publishing without any repo change. npm’s trusted publishing docs only require a minimum npm version (>=11.5.1), so pinning to a known-compatible major/minor (instead of latest) avoids unexpected CI regressions.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant