Skip to content

Validate LLM API response fields to prevent silent failures #30

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
claude merged 1 commit into from
Aug 26, 2026
Merged

Validate LLM API response fields to prevent silent failures #30

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 19 additions & 0 deletions agent/core/llm.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,23 @@ def __init__(self, config: LLMConfig):
self.config = config
self.base_url = config.base_url.rstrip("/")

def _validate_response(self, response: dict, required_fields: list[str]) -> None:
"""Validate that response contains expected fields.

Args:
response: The response dict to validate.
required_fields: List of field names that must be present.

Raises:
OllamaError: If any required field is missing.
"""
missing = [field for field in required_fields if field not in response]
if missing:
raise OllamaError(
f"Malformed API response: missing required fields {missing}. "
f"Got: {response}"
)

def _request(
self,
endpoint: str,
Expand Down Expand Up @@ -144,6 +161,7 @@ def chat(
return self._stream_chat(data, timeout=timeout)

result = self._request("/api/chat", data, timeout=timeout)
self._validate_response(result, ["message"])
return result

def _stream_chat(
Expand Down Expand Up @@ -201,6 +219,7 @@ def generate(self, prompt: str, timeout: Optional[float] = None) -> str:
},
}
result = self._request("/api/generate", data, timeout=timeout)
self._validate_response(result, ["response"])
return result.get("response", "")

def pull_model(
Expand Down