Repository navigation
fix(pwa): offline start from the home screen - #100
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The manifest starts the installed app at
/?source=pwa, but the service worker cached pages under the exact request URL. The plain start page is cached as/, so launching the PWA from the home screen missed the cache and landed on/offline.htmlwhenever the network was unavailable.pageCacheKey()dropssourceandutm_*(and the fragment) from page URLs; filters, sorts and offsets stay part of the key.apple-touch-iconpointed at the maskable icon (over-padded on the iOS home screen); it now uses the regular 192px icon.Checks
npm run check0/0,npm test455 passed (3 new tests for start URL, real query params, campaign params),npm run buildok.Source/UTM variants map to the same entry.