Support Vial layout options - #29
Open
hazardouschurch wants to merge 1 commit into
Open
Conversation
Owner
|
Thanks, I will look into this more closely some day next week! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
KLE changes are to solve an annoyance for Svalboard users. The Svalboard has integrated pointer devices; using a pointer activates a layer so it flashes the secondary south keys. This is mostly due to them defaulting to a key rather than a pass-through in Vial. The mouse switches to another layer, causing the flash. That is not a bug.
Binding them as a pass-through or using the Sval board works. Without binding all layers, it works without the PR, but it flashes. It's just annoying. SvalBoard has options to have a secondary set of south keys. More users don't have them, as it's an experimental option. This was added/changed to remove the secondary keys in the setup.
Related issue
Referenced in #27
Type of change
Testing
Screenshots or recordings