β‘ Bolt: Optimize compareTo function #806
Closed
+106
β54
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
π‘ What: Optimized
compareTofunction insrc/index.ts.π― Why: Version comparison is a hot path. The previous implementation used expensive string operations (
replace,split) and regex.π Impact:
isAtLeast(valid): ~193ns -> ~47ns (4x faster)isAtLeast(valid with v): ~466ns -> ~48ns (10x faster)isAtLeast(invalid): ~112ns -> ~17.5ns (6x faster)π¬ Measurement: Validated with a temporary mitata benchmark (removed before commit) and existing test suite.
PR created automatically by Jules for task 6362510356372645368 started by @srod
Summary by cubic
Optimized version comparison by rewriting compareTo to a zero-allocation parser. isAtLeast is now ~4xβ10x faster with the same behavior and validation.
Refactors
Dependencies
Written for commit a2b1606. Summary will update on new commits.