-
Notifications
You must be signed in to change notification settings - Fork 4
🛡️ Sentinel: [HIGH] Fix DoS vulnerability in version comparison #805
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Introduced `MAX_VERSION_LENGTH` (256) check in `compareTo` to prevent ReDoS and memory exhaustion attacks from maliciously crafted version strings. This ensures input validation is fail-closed for excessively long inputs.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
|
Important Review skippedBot user detected. To trigger a single review, invoke the You can disable this status message by setting the Comment |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #805 +/- ##
===========================================
- Coverage 100.00% 97.95% -2.05%
===========================================
Files 1 1
Lines 46 49 +3
Branches 16 17 +1
===========================================
+ Hits 46 48 +2
- Misses 0 1 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Superseded by #826 - closing duplicate bot-generated PR |
Understood. Acknowledging that this work is now obsolete and stopping work on this task. |
Added
MAX_VERSION_LENGTHconstant (256) and a check incompareTofunction insrc/index.ts. This limits the length of version strings processed, preventing potential Denial of Service (DoS) attacks via CPU or memory exhaustion from extremely long strings. Verified with tests.PR created automatically by Jules for task 5783055142362756436 started by @srod
Summary by cubic
Fixes a DoS vulnerability in version comparison by capping version string length. compareTo now rejects inputs longer than 256 characters and returns NaN to fail closed.
Written for commit 38d314e. Summary will update on new commits.