Skip to content

🛡️ Sentinel: Enforce MAX_VERSION_LENGTH to prevent DoS #802

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
google-labs-jules wants to merge 1 commit into from
+14 −2
Closed

🛡️ Sentinel: Enforce MAX_VERSION_LENGTH to prevent DoS #802

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions bun.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 5 additions & 0 deletions src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,8 @@ export const EOL_DATES: Record<string, string> = {
"24": "2028-04-30",
};

const MAX_VERSION_LENGTH = 256;

/**
* Check if a major version is EOL.
*/
Expand Down Expand Up @@ -52,6 +54,9 @@ export const getVersion = (): NodeVersion => {
* Compare the current node version with a target version string.
*/
const compareTo = (target: string): number => {
if (target.length > MAX_VERSION_LENGTH) {
return NaN;
}
if (target !== target.trim() || target.length === 0) {
return NaN;
}
Expand Down
8 changes: 8 additions & 0 deletions src/security.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,4 +63,12 @@ describe("security fixes", () => {
const v = getVersion();
expect(v.isAtLeast("10.0.0")).toBe(true);
});

test("should reject version strings exceeding MAX_VERSION_LENGTH", () => {
const v = getVersion();
const longVersion = `${"1".repeat(300)}.0.0`;
// Should be fail-closed (return false) for all checks if string is too long
expect(v.isAtLeast(longVersion)).toBe(false);
expect(v.isBelow(longVersion)).toBe(false);
});
});