Repository navigation
chore(deps): bump Go dependencies - #197
Merged
Merged
Conversation
Update the direct and indirect Go modules to their latest releases, except containerlab, which stays on its current pin until v0.83.0. Notable bumps: - github.com/shirou/gopsutil/v4 v4.26.10 - go.yaml.in/yaml/v3 v3.0.6 - github.com/clabernetes/clabernetes v0.11.0 - k8s.io/apiextensions-apiserver v0.37.2, which pulls github.com/google/cel-go v0.29.2 (fixes the open cel-go advisory) - google.golang.org/grpc v1.85.0, golang.org/x/net v0.62.0 k8s.io/kube-openapi stays on its pin: the newest version needs structured-merge-diff v7, which apimachinery v0.37.2 does not support yet.
Service.Exec held containerlabMu for as long as the commands ran, so a long exec (a ping, a script) stalled every other lab operation on the server until it returned. A capture started next to such an exec only began once the exec finished, which made the capture stream test flaky. The lock and the working directory are now held only while the topology is loaded and the target containers are listed.
containerlab v0.83.0 runs SR Linux nodes in the network namespace of an internal holder container, as SR-SIM nodes already did. The runtime reports no address, network or published ports for a container that joins another's network namespace, and the holders are hidden from listings, so these nodes showed "N/A" and SSH access to them failed. Listings now give each such node the network of its holder before the holders are hidden. A listing filtered by container or node name does not include the holders, so they are listed for the node's lab. The SSH suite no longer takes "N/A" for an address while it waits for its lab.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates the direct and indirect Go modules to their latest releases, and pins containerlab to the v0.83.0 release.
Notable bumps
github.com/srl-labs/containerlabv0.83.0 (was a pre-release pseudo-version of v0.82.1)github.com/shirou/gopsutil/v4v4.26.10go.yaml.in/yaml/v3v3.0.6github.com/clabernetes/clabernetesv0.11.0k8s.io/apiextensions-apiserver/k8s.io/apiserverv0.37.2, which pullsgithub.com/google/cel-gov0.29.2google.golang.org/grpcv1.85.0,golang.org/x/netv0.62.0Held back
k8s.io/kube-openapi: the newest version needsstructured-merge-diff/v7, whichk8s.io/apimachineryv0.37.2 does not support yet.cel-gov0.32: this release moved to thecel.dev/cel-gomodule path. v0.29.2 already fixes the advisory.Security
Exec no longer holds the containerlab lock
Service.Execheld the server-widecontainerlabMufor as long as the exec'd commands ran, so a long exec stalled every other lab operation until it returned. In CI this madeTestCaptureStreamNeedsNoEdgesharkflaky: the capture waited behind the 6 s ping and then captured an idle link. The lock and the working directory now cover only loading the topology and listing the target containers.SR Linux nodes report their management address again
containerlab v0.83.0 runs SR Linux nodes in the network namespace of an internal holder container (
<node>-netns), as SR-SIM nodes already did. Docker reports no address, network or ports for a container that joins another's namespace, and the API hides the holders, so SR Linux nodes showedN/Aand SSH access to them failed in CI. Container listings now give each such node its holder's network before the holders are hidden, including lookups by container name.Testing
go build ./...,go vet ./...andgo test ./internal/...pass.N/A, after it as172.20.20.2/24, for lab-wide listings and for the lookup by container name the SSH handler uses.Closes #178
Closes #189
Closes #190