Add identifier filter to support dynamic and safe insertion of identifiers#33
Open
tomasfarias wants to merge 12 commits into
Open
Add identifier filter to support dynamic and safe insertion of identifiers#33tomasfarias wants to merge 12 commits into
tomasfarias wants to merge 12 commits into
Conversation
The identifier filter will safely escape any quotes as well as enclose strings in double quotes. To be used for table, field, schema and database names.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds an
identifierfilter to escape SQL identifiers, like table and field names. As mentioned in #32, this would allow for safe and dynamic insertion of table and field names. Currently, this is possible via thesqlsafefilter but we delegate the responsibility of escaping strings to the user.The implementation will depend on database engine, which is why a new
db_engineparameter was added. I've implemented the filter for escaping strings in Postgres, although I would be willing to include more alternatives in this PR if that's needed to be considered complete.On invalid (not implemented or non-existent) engines, a
ValueErroris raised. Should I use instead a new exception inheriting fromJinjaSqlException?