Harden Braid CI orchestration against false green - #95
Merged
Merged
Conversation
srinji-kaggss
force-pushed
the
fix/fail-closed-ci-orchestration
branch
from
August 30, 2026 20:28
8a34f0b to
3b8dcea
Compare
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on main at
3a89e608. Advances #78.The gap
Braid's documented assurance floor was not the floor GitHub actually executed. The workflow could turn an API failure into "no stack blocker", external actions used mutable refs, path classification could skip required lanes, one job had no timeout, and cleanup could run before five run-owned target directories were finished. The documented Keel command also targeted a deleted Node adapter.
That means a green run could describe orchestration success without proving that the intended work ran.
The fix
v7.0.1on its declared Node 24 runtime.always().keelinvocation and truth-sync the assurance documentation.I rejected expanding the source classifier. Every new workflow, script, or data extension would reopen another skip hole, while this repository's required gate is fast enough to run for every change.
Real user path
Green path:
Red path:
The policy self-test also injects each prohibited workflow shape and requires a nonzero result before accepting the checker.
Proof of teeth
continue-on-error: trueThe documented Keel gate did not exist
The old adapter expected
keel/src/run.mjs, but the current Keel is native and not hermetically distributed to Braid CI. This change makes that absence explicit rather than preserving a stale success claim. Native Keel remains diagnostic until #78 establishes a reproducible distribution and closes the existing findings.Full CI, run locally at
3b8dcead8d5d8a26e5a72ff14c6097416544af10.wwfd/local-ci.shadmit1fac13b0e2798ef3540052a1e9ce0468b3c0fc943d6beb472494554edc1c98e5afaa7dcc9ab2f7d1530da72306c7d821c573f8aa9eda2b5c6e463f121f634acdccedc469e6b0513720969ce1a4f169f53365eeadbc853042c411b44c1f15b71fc0aeda7f6a8941dced115397d191c664532f0f5d895a0f1db09ed4b433abbbbaWhat is still not done