Add short flags and fix conflicting host flag#24
Open
rafaelespinoza wants to merge 6 commits intosrc-d:masterfrom
Open
Add short flags and fix conflicting host flag#24rafaelespinoza wants to merge 6 commits intosrc-d:masterfrom
rafaelespinoza wants to merge 6 commits intosrc-d:masterfrom
Conversation
The -h flag conflicts with help. Now you don't need to type out the entire long-form of the flag to specify a host. Signed-off-by: Rafael Espinoza <rafael@rafaelespinoza.com>
Signed-off-by: Rafael Espinoza <rafael@rafaelespinoza.com>
Signed-off-by: Rafael Espinoza <rafael@rafaelespinoza.com>
Didn't do Put.TTR flag since it'd conflict with Tube. Signed-off-by: Rafael Espinoza <rafael@rafaelespinoza.com>
Signed-off-by: Rafael Espinoza <rafael@rafaelespinoza.com>
fe928a4 to
b26d609
Compare
Signed-off-by: Rafael Espinoza <rafael@rafaelespinoza.com>
e4e0a9d to
abe3fa0
Compare
aa68adb to
b26d609
Compare
rafaelespinoza
added a commit
to rafaelespinoza/beanstool
that referenced
this pull request
Oct 1, 2025
This squashed commit is the same set of changes in src-d#24, as of 2025-10-01. Squashed commit of the following: commit abe3fa0 Author: Rafael Espinoza <rafael@rafaelespinoza.com> Date: Sat Sep 12 12:04:59 2020 -0700 fix two build issues Signed-off-by: Rafael Espinoza <rafael@rafaelespinoza.com> commit b26d609 Author: Rafael Espinoza <rafael@rafaelespinoza.com> Date: Sun Aug 30 16:56:03 2020 -0700 fix typo in Tail.Action flag usage Signed-off-by: Rafael Espinoza <rafael@rafaelespinoza.com> commit d39941b Author: Rafael Espinoza <rafael@rafaelespinoza.com> Date: Sun Aug 30 16:54:34 2020 -0700 Add most remaining shortflags Didn't do Put.TTR flag since it'd conflict with Tube. Signed-off-by: Rafael Espinoza <rafael@rafaelespinoza.com> commit be8b7c2 Author: Rafael Espinoza <rafael@rafaelespinoza.com> Date: Sun Aug 30 16:45:48 2020 -0700 Add short flags for num Signed-off-by: Rafael Espinoza <rafael@rafaelespinoza.com> commit 28c6454 Author: Rafael Espinoza <rafael@rafaelespinoza.com> Date: Sun Aug 30 16:42:36 2020 -0700 Add short flag for state Signed-off-by: Rafael Espinoza <rafael@rafaelespinoza.com> commit 66403be Author: Rafael Espinoza <rafael@rafaelespinoza.com> Date: Sun Aug 30 16:39:51 2020 -0700 fix(cli): Change short host flag to -H The -h flag conflicts with help. Now you don't need to type out the entire long-form of the flag to specify a host. Signed-off-by: Rafael Espinoza <rafael@rafaelespinoza.com> Signed-off-by: Rafael Espinoza <rafael@rafaelespinoza.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a nice tool. But there are some minor usability annoyances with the input flags.
Addresses the
host=flag short-form that conflicts with--help's short form. Both are-handhelptakes precedence. Get around this by specifying an alternative short-form forhost. This is similar to #22.Fix a typo in usage text.
Adds some other missing short-form flags.
I was careful to look for creating conflicts and couldn't find any new ones. Going through each subcommand's usage func shows that it still works. From what I understand, if there was a conflicting flag, then
beanstool <subcommand> -hwould output something like:Which doesn't seem to happen.
Let me know what you think, thanks.