Fix scripts/update-contributors.pl CONTRIBUTORS screening #2356
+8
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e#2125) Possible unintended interpolation of @users in string Bareword "true" not allowed Bareword "false" not allowed Execution of ... aborted due to compilation errors Recent commit daa76f4 broke scripts/update-contributors.pl syntax (see error messages quoted above) and its lower-case comparison logic, effectively disabling CONTRIBUTORS checks. Also do not hide update-contributors.pl execution failures. Buggy failure detection contributed to the above problems ignored by CI tests.
squid-anubis
added
the
M-failed-description
This comment was marked as resolved.
This comment was marked as resolved.
yadij
changed the title
squid-anubis
removed
the
M-failed-description
yadij
approved these changes
Jan 17, 2026
squid-anubis
pushed a commit
that referenced
this pull request
Jan 30, 2026
Possible unintended interpolation of @users in string
Bareword "true" not allowed
Bareword "false" not allowed
Execution of ... aborted due to compilation errors
Recent commit daa76f4 broke scripts/update-contributors.pl
syntax (see error messages quoted above) and its lower-case
comparison logic, effectively disabling CONTRIBUTORS checks.
Also do not hide update-contributors.pl execution failures.
Buggy failure detection contributed to the above problems
ignored by CI tests.
squid-anubis
added
M-waiting-staging-checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recent commit daa76f4 broke scripts/update-contributors.pl
syntax (see error messages quoted above) and its lower-case
comparison logic, effectively disabling CONTRIBUTORS checks.
Also do not hide update-contributors.pl execution failures.
Buggy failure detection contributed to the above problems
ignored by CI tests.