Open
Conversation
Contributor
|
do you also need to update the |
Contributor
|
Nit: if we're going to bother with the overall-commit template, we should fill it in. |
fka3
reviewed
Sep 18, 2024
Contributor
fka3
left a comment
fka3
left a comment
There was a problem hiding this comment.
Left several comments, only one of them blocking: IIUC what package.json says, then the comment in android/app/build.gradle is wrong (and should probably just go away entirely, but is definitely wrong)
...k-react-native-quickstart/android/app/src/main/java/com/rnreadersdksample/MainApplication.kt
Outdated
Show resolved
Hide resolved
brandonjenniges
requested changes
Sep 23, 2024
| @@ -1,13 +1,17 @@ | |||
| ## Changelog | |||
|
|
|||
| ### v1.4.6 Sep 18, 2024 | |||
Member
There was a problem hiding this comment.
I think the latest entry in the changelog should be:
v1.7.7 Oct 16, 2024
- Upgrade Reader SDK version support to 1.7.4 for iOS
- Support CompileSDK and targetSDK 34 on Android
So replace your changes adding ### v1.4.6 Sep 18, 2024 with that.
|
|
||
| * Upgrade Reader SDK version support to 1.7.5 for Android | ||
| * Support CompileSDK and targetSDK 33 on Android | ||
| * Support CompileSDK and targetSDK 34 on Android |
Member
There was a problem hiding this comment.
Revert this change, see comment above for v1.7.7 Oct 16, 2024 entry.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Related issues
Fix #
Changelog
Test Plan