This repository was archived by the owner on Apr 23, 2021. It is now read-only.
Open
Conversation
Contributor
|
Looks good to me. Are you going to add the transaction tests in this PR too? |
tristansokol
force-pushed
the
tristans/update-tests
branch
from
c940e8f to
1ba5a90
Compare
bunnyc1986
approved these changes
May 6, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add the existing customer tests, and remove all of the test stubs for the model tests (that I don't think we will implement).
Todo: Add existing transaction tests.