Repository navigation
Test: note when the AppLocker logs can't record anything (#74) - #81
Merged
Merged
Conversation
When the AppLocker channels are selected, Test now adds an informational note after the storage check: AppLocker not available on this edition, no AppLocker policy in effect (the logs will stay empty), or the number of rules in effect. Read-only (Get-AppLockerPolicy -Effective), never a FAIL; the kit never creates an AppLocker policy. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Warning Review limit reachedNext included review available in 35 minutes. View limit detailsLimit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: Repository: spydisec/WinLogKit/.coderabbit.yaml Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (4)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #74. From the review of Yamato WELA #381.
The four AppLocker channels pass Test as enabled, but record nothing unless an AppLocker policy is in effect (the settings table's own Purpose text says so). When they're selected, Test now ends with an AppLocker note:
Get-AppLockerPolicynot available: AppLocker isn't available on this edition, so the logs stay empty. (Exercised on this Windows 11 Home machine, where the cmdlet doesn't exist.)Informational only, never a FAIL. Read-only (
Get-AppLockerPolicy -Effective); a self-check confirms Test never callsSet-AppLockerPolicy. Commands page updated.Checks: Pester 65/65 on PowerShell 7 and 5.1; PSScriptAnalyzer clean for the kit;
mkdocs build --strictpasses. The "policy present / absent" branches need a Pro, Enterprise or Server host to see live.🤖 Generated with Claude Code