Repository navigation
SMB: audit insecure guest logons; fix swapped SMB event IDs (#72) - #79
Merged
Merged
Conversation
New Core SMB audit item AuditInsecureGuestLogon (client side; Set-SmbClientConfiguration; event 31997 in SmbClient/Audit), mapped to LanmanWorkstation/AuditInsecureGuestLogon and Network > Lanman Workstation > Audit insecure guest logon; the GPO pack's registry.txt carries it. The server-side switch is left out: its event (3023) goes to SMBServer/Operational, which the kit doesn't collect. The settings table had SMB signing and encryption event IDs swapped; per the SMBServer / SMBClient provider manifests 3021 / 31998 are signing and 3022 / 31999 encryption. SMB items are now described as Windows 11 24H2 / Server 2025 and later. Presets, Reference and policy pages regenerated. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Warning Review limit reachedNext included review available in 46 minutes. View limit detailsLimit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: Repository: spydisec/WinLogKit/.coderabbit.yaml Review profile: CHILL Plan: Advanced Run ID: ⛔ Files ignored due to path filters (4)
📒 Files selected for processing (13)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #72. From the review of Yamato WELA #377.
Added: insecure guest logon auditing (client side)
AuditInsecureGuestLogon(Set-SmbClientConfiguration -AuditInsecureGuestLogon $true). The SMB client logs event 31997 in SmbClient/Audit (a kit channel) when a share logs it on as Guest. Confirmed on this Windows 11 machine: the cmdlet parameter exists andGet-SmbAuditStatereads it (currently False, so Enable would turn it on).LanmanWorkstation/AuditInsecureGuestLogon, Group Policy Network > Lanman Workstation > Audit insecure guest logon; the GPO pack'sregistry.txtcarriesSOFTWARE\Policies\Microsoft\Windows\LanmanWorkstation\AuditInsecureGuestLogon = 1.Set-SmbServerConfiguration -AuditInsecureGuestLogonwrites event 3023 to SMBServer/Operational (per the provider manifest), a log the kit doesn't collect. Adding it would need that channel too; noted for later.Fixed: swapped SMB event IDs
Get-WinEvent -ListProvider) define 3021 / 31998 = signing and 3022 / 31999 = encryption. Purpose text corrected; the Reference page and Safety FAQ follow.Presets (role presets select the new item; ASD stays faithful), Reference, Settings catalog and Group Policy pages regenerated.
Checks: Pester 62/62 on PowerShell 7 and 5.1; PSScriptAnalyzer clean for the kit;
mkdocs build --strictpasses.🤖 Generated with Claude Code