Use extended regex for replace_text.#215
Closed
weakish wants to merge 2 commits intosprinkle-tool:masterfrom
Closed
Use extended regex for replace_text.#215weakish wants to merge 2 commits intosprinkle-tool:masterfrom
weakish wants to merge 2 commits intosprinkle-tool:masterfrom
Conversation
Previously it used basic regex.
Contributor
|
Please split out npm change. Change to replace text would need to be some type of option because as is it would be potentially breaking change. |
Contributor
Author
Sorry. 8dfd022 is identical to 572f4b6 (already included in #216).
👍 Close this pull request now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously it used basic regex.