fix(mcp-apps-server): put CSP meta on resource read response - #140
Open
arimu1 wants to merge 1 commit into
Open
Conversation
arimu1
force-pushed
the
fix/mcp-apps-csp-on-resource-response-136
branch
from
July 26, 2026 03:51
b11efad to
facd414
Compare
Per MCP Apps spec, _meta.ui.csp belongs on contents[] objects returned by the resource read callback, not on the resource definition via metaProvider. Fixes spring-projects#136 Signed-off-by: arimu1 <19286898+arimu1@users.noreply.github.com>
arimu1
force-pushed
the
fix/mcp-apps-csp-on-resource-response-136
branch
from
July 26, 2026 03:51
facd414 to
47cc2f5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #136
The MCP Apps spec requires
_meta.ui.csp(and related UI metadata) on thecontents[]objects returned by the resource read callback, not on the resource definition registered via@McpResource/metaProvider.This change:
CspMetaProviderfrom the@McpResourceregistrationReadResourceResultwithTextResourceContentsthat carries_meta.ui.csp.resourceDomainsforhttps://unpkg.comDiceMetaProvider(_meta.ui.resourceUri) unchanged — that belongs on the tool, not the resource definitionTest plan
./gradlew buildinmodel-context-protocol/mcp-apps-server(Java 25 toolchain)McpAppsServerApplicationTests)AI assistance disclosure
This fix was AI-assisted (Composer/Cursor) and human-reviewed per Spring AI CONTRIBUTING accountability guidelines.
Made with Cursor