You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This project has SWIFT_DEFAULT_ACTOR_ISOLATION = MainActor, so file-level functions/properties are inferred as main-actor isolated unless marked otherwise.
pixelSize is used from WallpaperManager.renderForScreen, which is already nonisolated, so the property also needs to be explicitly nonisolated.
renderThumbnails(jobs:) is called from a Task.detached thumbnail-rendering path, so it also needs to be callable outside the main actor. The previous @Sendable annotation conflicts with the inferred main-actor isolation and triggers a Swift 6 diagnostic. Making the function nonisolated is the relevant fix here; the detached task closure remains the concurrency boundary, and ThumbnailJob / ThumbnailResult already cover the sendability requirements for the values crossing that boundary.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes image sizing for files whose DPI metadata causes
NSImage.sizeto report point dimensions instead of actual pixels.Example: a 7680x1440 JPEG with 1 DPI metadata was shown as 552960x103680+ in the editor.
Changes:
NSImage.pixelSizehelper usingNSBitmapImageRep.pixelsWide/pixelsHigh, falling back toCGImage.width/heightValidation: