Update documentation for conditional query operators and add :notlike#291
Open
mmethner wants to merge 17 commits intospotorm:masterfrom
Open
Update documentation for conditional query operators and add :notlike#291mmethner wants to merge 17 commits intospotorm:masterfrom
mmethner wants to merge 17 commits intospotorm:masterfrom
Conversation
Author
|
Hi @vlucas I would like to add a PR for php8 support, but this pr seems to be merged first, before I contribute the next pr. Would you like to review and merge? |
vlucas
reviewed
Aug 23, 2023
| "vlucas/valitron": "~1.1", | ||
| "doctrine/dbal": "^2.5.4", | ||
| "sabre/event": "~2.0" | ||
| "php": ">= 8.1.11", |
Collaborator
There was a problem hiding this comment.
If the PHP version is going to be bumped up to PHP8+, then we will have to do a major version release since this is a huge breaking change.
Author
There was a problem hiding this comment.
Hi @vlucas It looks like I did something wrong with the branch and repository I pushed to. Especially the last commit today was addressed to my fork. The compatiblity for 8.1 nevertheless is given. Are you willing to make a release out of it?
Collaborator
There was a problem hiding this comment.
Yes, I can do a major release to support PHP8+.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This updates the Readme to explain conditional queries and how
\Spot\Query::addWhereOperatorThanks to @marcojetson for his work on #161 back in 2016.