Skip to content

Feature/con 26736 validate helm version #137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dahanmoshe1991 wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Feature/con 26736 validate helm version #137

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
098ec47
add helm check version
dahanmoshe1991 Jun 4, 2024
80f3701
fix helm check
dahanmoshe1991 Jun 5, 2024
75e2ec8
fix helm param
dahanmoshe1991 Jun 5, 2024
4d58f4b
helm version 3.9.0
dahanmoshe1991 Jun 5, 2024
dede70e
remove else
dahanmoshe1991 Jun 5, 2024
72c6e70
Merge remote-tracking branch 'origin/main' into feature/CON-26736_val…
dahanmoshe1991 Jun 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions charts/ocean-kubernetes-controller/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,8 @@ helm install spot spot/ocean-kubernetes-controller \

Kubernetes: `>=1.20.0-0`

Helm: `>=3.9.0`

| Repository | Name | Version |
|------------|------|---------|
| https://kubernetes-sigs.github.io/metrics-server | metrics-server | 3.11.0 |
Expand Down
16 changes: 15 additions & 1 deletion charts/ocean-kubernetes-controller/templates/_helpers.tpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -352,4 +352,18 @@ or if another log shipping destination host is specified.
true
{{- end }}
{{- end }}
{{- end }}
{{- end }}

{{/*
This function validates the Helm version. It checks if the Helm version is 3.7 or higher.
If the Helm version is less than 3.7, it will cause the Helm operation to fail with an error message.
*/}}
{{- define "ocean-kubernetes-controller.validateHelmVersion" -}}
{{- $helmVersion := .Capabilities.HelmVersion.Version }}
{{- if $helmVersion -}}
{{- if semverCompare ">=v3.9.0" (semver $helmVersion).String -}}
{{- else -}}
{{- fail "Helm version 3.9.0 or higher is required to install this chart" -}}
{{- end -}}
{{- end -}}
{{- end -}}
1 change: 1 addition & 0 deletions charts/ocean-kubernetes-controller/templates/deployment.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
{{ include "ocean-kubernetes-controller.validateHelmVersion" . }}
{{ include "ocean-kubernetes-controller.deployMetricsServer" . }}
apiVersion: apps/v1
kind: Deployment
Expand Down