Fix case-sensitive AD self-add group comparison#4112
Open
srkyn wants to merge 1 commit into
Open
Conversation
Author
|
Rechecked this branch after the failed CI run. The PR diff is still limited to the intended case-insensitive comparison plus version/date bump, and the detection YAML parses cleanly. Local sanity check passed:
The two failing GitHub Actions jobs appear to be blocked before exercising this detection because forked PR runs do not receive Splunk credentials:
The other checks (YAML Validation, build, and response template build) passed. |
Contributor
|
@srkyn - thank you for the PR and doing the testing locally, I think the fix makes sense and I will raise this issue of unit-testing needing creds. We recently updated our tooling and didnt think of this issue coming up! I will get back to you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the
Windows AD add Self to Groupanalytic so the self-add comparison is case-insensitive:Why
Issue #4105 reports that matching can fail when the same account appears with different casing, for example
user=DA-1andsrc_user=da-1.Validation
Result:
Fixes #4105.