[spizeck]

Closes #250

Summary

Removes the stale external install of web-design-guidelines and installs the canonical org-managed copy, per the #186/#187 enforcement (STALE-VENDORED detection in install-skills.mjs).

The vendored copy at .agents/skills/web-design-guidelines/ was installed by the skills CLI from vercel-labs/agent-skills and fetched mutable upstream main/ instructions at invocation — the prompt-injection surface the org replacement was created to close. With the same name vendored outside the canonical dir, agent discovery could not be trusted to prefer the approved copy.

Changes

Action	Path	Tool
Removed vendored skill	.agents/skills/web-design-guidelines/	npx skills remove web-design-guidelines
Removed lockfile entry	skills-lock.json (entry only; all other pins untouched)	skills remove
Installed org copy	.devin/skills/web-design-guidelines/ (pinned snapshot vercel-labs/web-interface-guidelines@434b7f9 + reviewed corrections)	install-skills.mjs (app-foundations @ 4208eb4c, post-#187)
Provenance recorded	.devin/agent-skills-state.json	installer-written hashes

Verification (installer, app-foundations main)

Before: check: 2 issue(s) — MISSING: web-design-guidelines + STALE-VENDORED: web-design-guidelines at .agents/skills/web-design-guidelines.

After (node install-skills.mjs --repo . --check):

  OK: engineering-standards
  OK: pr-workflow
  OK: ui-ux-standards
  OK: production-readiness
  OK: privacy-consent
  OK: discovery-first-development
  OK: web-design-guidelines
  INSTALLED: vercel-react-best-practices
  INSTALLED: firebase-basics
  INSTALLED: firebase-auth-basics
  INSTALLED: firebase-firestore
  INSTALLED: firestore-rules-creation
  INSTALLED: firebase-security-rules-auditor
  INSTALLED: sentry-debug-issue
  INSTALLED: sentry-fix-stack-traces
  INSTALLED: next-dev-loop
check: clean

• Zero STALE-VENDORED, zero duplicates, zero missing manifest-required skills.
• All approved external pins preserved (lockfile diff removes only the wdg entry).
• --detect suggests the same skill set — nothing stale reported.
• npm run check (docs + env + hygiene): clean. No application code touched.

Test plan

• install-skills.mjs --check clean post-change
• --detect reports no stale findings
• npm run check passes
• CI

Generated with Devin

Summary by Sourcery

Replace the stale vendored web-design-guidelines skill with the canonical org-managed pinned copy.

New Features:

• Install the approved, pinned web-design-guidelines skill in the canonical .devin skills directory with reviewed accessibility guidance and provenance metadata.

Bug Fixes:

• Remove the stale vendored web-design-guidelines copy and lockfile entry to eliminate duplicate and mutable external skill discovery.

Enhancements:

• Record installer-managed skill state and hashes for the approved web-design-guidelines snapshot.

Tests:

• Verify the skill installation is clean, with no missing or stale-vendored skills, and that repository checks pass.

Summary by CodeRabbit

• New Features
  • Added a web design review skill that checks specified files against accessibility, usability, and interface guidelines.
  • The review guidance is bundled for consistent use without fetching guidelines from the network. If no files are specified, the skill asks which files to review.

[sourcery-ai]

Sorry @spizeck, this account has used its review budget of 1,500,000 diff characters for the last 7 days.

You can request another review in 1 minute by commenting @sourcery-ai review. Upgrade to get a review now.

[vercel]

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated
seasaba-web	Ready	Preview	Oct 13, 2026 12:36am UTC

[sourcery-ai]

Reviewer's Guide

Migrates web-design-guidelines from the mutable, duplicate .agents installation to the canonical .devin skill, bundling a pinned and reviewed guideline snapshot, updating provenance and lock state, and verifying that installer and repository checks remain clean.

File-Level Changes

Change	Details	Files
Replace the stale externally vendored skill with the canonical org-managed, pinned implementation.	Delete the duplicate .agents skill copy. Add the org-managed skill and bundled guideline reference at the pinned upstream revision. Remove only the obsolete external lockfile entry. Record installed-skill provenance and content hashes.	.agents/skills/web-design-guidelines/SKILL.md .devin/skills/web-design-guidelines/SKILL.md .devin/skills/web-design-guidelines/references/web-interface-guidelines.md skills-lock.json .devin/agent-skills-state.json
Harden the skill against mutable upstream instruction fetching and preserve reviewed behavior corrections.	Instruct the skill to use only its bundled guidelines and never fetch network content at review time. Document the upstream revision, upstream hash, installed hash, and reviewed accessibility correction. Provide the terse, file-grouped review output format and comprehensive UI guideline rules.	.devin/skills/web-design-guidelines/SKILL.md .devin/skills/web-design-guidelines/references/web-interface-guidelines.md
Verify the repository skill installation state and project checks after migration.	Confirm installer check is clean with no missing, duplicate, or stale-vendored skills. Confirm detection reports no stale findings and general repository checks pass.	.devin/agent-skills-state.json

Assessment against linked issues

Issue	Objective	Addressed	Explanation
#250	Remove the stale externally vendored web-design-guidelines skill and its skills-lock.json entry so agents cannot discover or run the mutable upstream copy.	✅
#250	Install the pinned, org-managed web-design-guidelines copy under .devin/skills/, including its bundled guidelines and provenance/state metadata.	✅
#250	Verify the repository has no missing or stale vendored skills after the replacement.	✅

Possibly linked issues

• Remove stale vendored web-design-guidelines + install org-managed copy #250: The PR performs the issue’s requested cleanup, installs the org copy, and updates provenance and lockfile state.

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[chatgpt-codex-connector]

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review	Status	Commit	Review trigger
🔒 Security Review	✅ Completed 2026-10-13T00:37:56.860646Z	3a168e0	PR opened

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

• Configuration used: Organization UI
• Review profile: CHILL
• Plan: Advanced
• Run ID: cfa676a3-c1ce-443f-b585-d53b0ef375b8

📥 Commits

Reviewing files that changed from the base of the PR and between 7b30bd9 and 3a168e0.

📒 Files selected for processing (5)

• .agents/skills/web-design-guidelines/SKILL.md
• .devin/agent-skills-state.json
• .devin/skills/web-design-guidelines/SKILL.md
• .devin/skills/web-design-guidelines/references/web-interface-guidelines.md
• skills-lock.json

💤 Files with no reviewable changes (2)

• .agents/skills/web-design-guidelines/SKILL.md
• skills-lock.json

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 1 remain after this review.

📝 Walkthrough

Walkthrough

The PR replaces the vendored web-design-guidelines skill with an org-managed skill and bundled guideline reference. It records the skill hashes and source revision in Devin state, and removes the prior skills-lock entry.

Changes

Web design guidelines skill replacement

Layer / File(s)	Summary
Define the local review workflow .devin/skills/web-design-guidelines/SKILL.md, .devin/skills/web-design-guidelines/references/web-interface-guidelines.md, .agents/skills/web-design-guidelines/SKILL.md	The new skill directs reviews to use a bundled guideline reference without network fetching. The reference contains review rules and finding-format instructions. The prior vendored skill is deleted.
Update installed skill metadata .devin/agent-skills-state.json, skills-lock.json	Devin state records the new skill’s file hashes and source revision. The skills lock no longer lists the vendored skill.

Priority: ⬇️ Low

Merge Risk: ⚪ Minimal · up to 3a168

The PR replaces remote guidance with a bundled, corrected reference. No specific merge-blocking risk was established; the installer check and aggregate provenance remain independently unverified.

Architecture Summary

Architecture risk: 🔵 Low · up to 3a168

The change affects 1 system.

Changed systems: skills-lock.json

Architecture concerns
No architecture-level concerns identified.

Review details

Systems and components

• observed — skills-lock.json (service) was modified; 1 changed file maps to changed impact.

Before / after behavior

• observed — Modified behavior in skills-lock.json: Removed the web-design-guidelines skill lock entry, which referenced vercel-labs/agent-skills and its web-design-guidelines skill path and computed hash.
• observed — Modified behavior in .agents/skills/web-design-guidelines/SKILL.md: Deleted the skill definition and its instructions for fetching guidelines, reviewing specified files, formatting findings, and requesting files when none are specified.
• observed — Modified behavior in .devin/agent-skills-state.json: Adds the web-design-guidelines skill entry with two file hashes and an installation timestamp.
• observed — Modified behavior in .devin/agent-skills-state.json: Updates the recorded source repository revision.

Pre-merge checks · 4

Passed checks (4 passed)

Check name	Status	Explanation
Description Check		Check skipped - CodeRabbit’s high-level summary is enabled.
Title check		The title clearly and concisely describes the main change: replacing the vendored web-design-guidelines skill with the org-managed copy.
Linked Issues check		Issue #250 is the active directly linked issue. The reviewed head contains .devin/skills/web-design-guidelines/SKILL.md and its pinned reference, plus .devin/agent-skills-state.json with the manag…
Out of Scope Changes check		The reported changes are limited to the stale skill removal, its lockfile entry removal, the org-managed skill and reference, and installer provenance state. The lockfile inspection shows the remainin…

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

_{Comment @coderabbitai help to get the list of available commands.}