test(brand): assert manifest icon purpose is exactly "any" by spizeck · Pull Request #159 · spizeck/deepdivebrewing-web

spizeck · 2026-10-03T23:03:55Z

Summary

Follow-up to #157 — this commit was pushed after #157 was squash-merged, so it did not ride along. Addresses the remaining CodeRabbit nitpick on that PR: the manifest test now asserts purpose is exactly "any" rather than merely truthy, so a future "maskable" change cannot pass while the badge art is not safe-zone guaranteed.

Changes

tests/brand-assets.test.ts — strict purpose === "any" assertion

Verification

npx tsc --noEmit — clean
node --import tsx --test tests/brand-assets.test.ts — 5/5 pass

Risk / deployment notes

No secrets, credentials, or private data were committed.

Generated with Devin

Summary by Sourcery

Enforce the manifest icon purpose required for the badge artwork.

Enhancements:

Strengthen brand asset manifest tests to require every icon to declare the exact purpose "any".

Tests:

Update manifest icon coverage to reject incorrect or future "maskable" purposes.

Summary by CodeRabbit

Tests
- Updated the manifest icon check to require the purpose value to be exactly "any".

The badge art is not maskable safe-zone guaranteed, so a "maskable" purpose must never pass the test. Generated with [Devin](https://devin.ai) Co-Authored-By: Devin <158243242+devin-ai-integration[bot]@users.noreply.github.com>

sourcery-ai

Sorry @spizeck, this account has used its review budget of 1,500,000 diff characters for the last 7 days.

You can request another review in 10 hours by commenting @sourcery-ai review. Upgrade to get a review now.

vercel · 2026-10-03T23:04:01Z

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated
deepdivebrewing-web	Ready	Preview	Oct 4, 2026 12:33am UTC

chatgpt-codex-connector · 2026-10-03T23:04:04Z

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review	Status	Commit	Review trigger
🔒 Security Review	✅ Completed 2026-10-03T23:06:21.622032Z	`ce63dcd`	PR opened

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

sourcery-ai · 2026-10-03T23:04:07Z

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

The PR tightens the brand asset manifest test so every icon must explicitly declare purpose "any", preventing an incompatible "maskable" value from passing unnoticed while preserving the existing icon wiring checks.

File-Level Changes

Change	Details	Files
Strengthen manifest icon validation to require the exact supported purpose value.	Replace the truthiness check with a strict equality assertion against "any". Document that the badge artwork is not safe-zone guaranteed for "maskable" use. Retain existing PNG type and required-size coverage.	`tests/brand-assets.test.ts`

Tips and commands

Interacting with Sourcery

Trigger a new review: Comment @sourcery-ai review on the pull request.
Continue discussions: Reply directly to Sourcery's review comments.
Generate a GitHub issue from a review comment: Ask Sourcery to create an
issue from a review comment by replying to it. You can also reply to a
review comment with @sourcery-ai issue to create an issue from it.
Generate a pull request title: Write @sourcery-ai anywhere in the pull
request title to generate a title at any time. You can also comment
@sourcery-ai title on the pull request to (re-)generate the title at any time.
Generate a pull request summary: Write @sourcery-ai summary anywhere in
the pull request body to generate a PR summary at any time exactly where you
want it. You can also comment @sourcery-ai summary on the pull request to
(re-)generate the summary at any time.
Generate reviewer's guide: Comment @sourcery-ai guide on the pull
request to (re-)generate the reviewer's guide at any time.
Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
pull request to resolve all Sourcery comments. Useful if you've already
addressed all the comments and don't want to see them anymore.
Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
request to dismiss all existing Sourcery reviews. Especially useful if you
want to start fresh with a new review - don't forget to comment
@sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

Enable or disable review features such as the Sourcery-generated pull request
summary, the reviewer's guide, and others.
Change the review language.
Add, remove or edit custom review instructions.
Adjust other review settings.

Getting Help

Contact our support team for questions or feedback.
Visit our documentation for detailed guides and information.
Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

coderabbitai · 2026-10-03T23:04:19Z

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

Important

Review skipped

Review was skipped as selected files did not have any reviewable changes.

⚙️ Run configuration

Configuration used: Organization UI
Review profile: CHILL
Plan: Advanced
Run ID: 3c485cec-716a-4a66-974f-6435a5a174a1

📥 Commits

Reviewing files that changed from the base of the PR and between ce63dcd and 75bc72e.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

🔍 Trigger review

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI
Review profile: CHILL
Plan: Advanced
Run ID: 53934c7c-39c6-49dd-a2dc-9018fc3c8532

📥 Commits

Reviewing files that changed from the base of the PR and between a9afead and ce63dcd.

📒 Files selected for processing (1)

tests/brand-assets.test.ts

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 2 remain after this review.

📝 Walkthrough

Walkthrough

The manifest icon test now requires each icon’s purpose to equal "any".

Changes

Manifest icon check

Layer / File(s)	Summary
Require the expected icon purpose `tests/brand-assets.test.ts`	The test replaces the truthiness check with a strict assertion that each icon’s `purpose` equals `"any"`. It also updates the failure message.

Priority: ⬇️ Low

Merge Risk: ⚪ Minimal · up to ce63d

This change tightens a test without changing the manifest or shipped behavior; both icons already meet the assertion, so no merge risk remains.

Architecture Summary

Architecture risk: 🔵 Low · up to ce63d

The change affects 1 system.

Changed systems: tests

Architecture concerns
No architecture-level concerns identified.

Review details

Systems and components

observed — tests (service) was modified; 1 changed file maps to changed impact.

Before / after behavior

observed — Modified behavior in tests/brand-assets.test.ts: The manifest test replaces the truthiness check for icon.purpose with a strict assertion that it is "any", including an updated failure message.

🚥 Pre-merge checks | ✅ 4

✅ Passed checks (4 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly and concisely describes the main change: tightening the manifest icon test to require purpose "any".
Description check	✅ Passed	The description covers the summary, changes, verification, and risk notes required by the template. It reports relevant test results and confirms that no private data was committed.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

_{Comment @coderabbitai help to get the list of available commands.}

sourcery-ai

Sourcery assessment

Approved.

test(brand): assert manifest icon purpose is exactly "any"

ce63dcd

The badge art is not maskable safe-zone guaranteed, so a "maskable" purpose must never pass the test. Generated with [Devin](https://devin.ai) Co-Authored-By: Devin <158243242+devin-ai-integration[bot]@users.noreply.github.com>

sourcery-ai Bot reviewed Oct 3, 2026

View reviewed changes

vercel Bot deployed to Preview October 3, 2026 23:04 View deployment

Merge branch 'main' into fix/brand-manifest-purpose-test

75bc72e

vercel Bot deployed to Preview October 4, 2026 00:33 View deployment

sourcery-ai Bot approved these changes Oct 4, 2026

View reviewed changes

spizeck merged commit 25f43bd into main Oct 4, 2026
5 checks passed

spizeck deleted the fix/brand-manifest-purpose-test branch October 4, 2026 00:36

Navigation Menu

Repository navigation

test(brand): assert manifest icon purpose is exactly "any" - #159

test(brand): assert manifest icon purpose is exactly "any"#159
spizeck merged 2 commits into
mainfrom
fix/brand-manifest-purpose-test

spizeck commented Oct 3, 2026 •

edited by sourcery-ai Bot

Loading

Uh oh!

sourcery-ai Bot left a comment

Uh oh!

vercel Bot commented Oct 3, 2026 •

edited

Loading

Uh oh!

chatgpt-codex-connector Bot commented Oct 3, 2026 •

edited

Loading

Uh oh!

sourcery-ai Bot commented Oct 3, 2026

Reviewer's Guide

File-Level Changes

Interacting with Sourcery

Customizing Your Experience

Getting Help

Uh oh!

coderabbitai Bot commented Oct 3, 2026 •

edited

Loading

Review skipped

Walkthrough

Changes

Uh oh!

sourcery-ai Bot left a comment

Uh oh!

Uh oh!

This branch was successfully deployed

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Conversation

spizeck commented Oct 3, 2026 • edited by sourcery-ai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Changes

Verification

Risk / deployment notes

Summary by Sourcery

Summary by CodeRabbit

Uh oh!

sourcery-ai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

vercel Bot commented Oct 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

chatgpt-codex-connector Bot commented Oct 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codex Review Summary

Uh oh!

sourcery-ai Bot commented Oct 3, 2026

Reviewer's Guide

File-Level Changes

Interacting with Sourcery

Customizing Your Experience

Getting Help

Uh oh!

coderabbitai Bot commented Oct 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review skipped

Walkthrough

Changes

Architecture Summary

Uh oh!

sourcery-ai Bot left a comment

Choose a reason for hiding this comment

Sourcery assessment

Uh oh!

Uh oh!

This branch was successfully deployed

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

spizeck commented Oct 3, 2026 •

edited by sourcery-ai Bot

Loading

vercel Bot commented Oct 3, 2026 •

edited

Loading

chatgpt-codex-connector Bot commented Oct 3, 2026 •

edited

Loading

coderabbitai Bot commented Oct 3, 2026 •

edited

Loading