P3 conversion#75
Draft
itowlson wants to merge 4 commits into
Draft
Conversation
Signed-off-by: itowlson <ivan.towlson@fermyon.com>
Signed-off-by: itowlson <ivan.towlson@fermyon.com>
Signed-off-by: itowlson <ivan.towlson@fermyon.com>
Signed-off-by: itowlson <ivan.towlson@fermyon.com>
Contributor
Author
|
I tested it on a 1GB file and one thing that worries me is that calculating the ETag takes a while, which delays the start of download. But I don't think this is a regression so we can set it aside to ponder or document later. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WIP because I am not sure what to do about the composition samples. They should probably be modified to use the middleware API. But it looks like our SDKs don't surface that yet. There is a WIT directory of mystick things which I think is being manually bindgened somewhere so I guess I could copy the middleware world in there? And then shift things over to use Spin composition instead of manual wac. But I am not really sold on the value of this.
(Also the build commands in those samples use
cargo componentbut I'm guessing those should switch over towasm32-wasip2fairly easily - just noting it as something to do once we make a decision on what to do with them. In the meantime I expect this will cause CI to fail!)