Add separate sample Shim files for each architecture for Spin and Wastime shims#578
Open
kate-goldenring wants to merge 1 commit intospinframework:mainfrom
Open
Add separate sample Shim files for each architecture for Spin and Wastime shims#578kate-goldenring wants to merge 1 commit intospinframework:mainfrom
kate-goldenring wants to merge 1 commit intospinframework:mainfrom
Conversation
kate-goldenring
force-pushed
the
samples-with-arch
branch
from
f397c19 to
b2c5245
Compare
vdice
reviewed
Feb 14, 2026
Collaborator
There was a problem hiding this comment.
This will break existing helm releases of RCM which unfortunately point to main
Well, you haven't deleted test_shim_spin.yaml in this PR, so v0.1.0 RCM installations referencing this file should continue to work. (A couple CI test workflows reference the same file.)
Still, very much agreed about #580, which we should complete prior to the next release.
1 task
…mtime shims Signed-off-by: Kate Goldenring <kate.goldenring@fermyon.com>
kate-goldenring
force-pushed
the
samples-with-arch
branch
from
b2c5245 to
ca54344
Compare
12 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #576 by making it easier to install a specific arch of the shim. On release in the
Notes.txt, we should point to tagged references of the example file rather than referencing main. see #580.Also adds in Wasmtime shim example.