Rebalancing#4
Open
karuan wants to merge 5 commits into
Open
Conversation
vibhaa
reviewed
Mar 13, 2019
vibhaa
reviewed
Mar 13, 2019
vibhaa
reviewed
Mar 13, 2019
vibhaa
reviewed
Mar 13, 2019
vibhaa
reviewed
Mar 13, 2019
| double oldBalance = nodeToPaymentChannel[key].balance; | ||
| simtime_t zeroStartTime = nodeToPaymentChannel[key].zeroStartTime; | ||
|
|
||
| if ( ( oldBalance == 0 ) && ( zeroStartTime >= 0) && ( zeroStartTime + _rebalanceTimeReq <= simTime()) ) |
Member
There was a problem hiding this comment.
minor nit: can you change this to simTime > zeroStartTime + _rebalanceTimeReq? (more intuitive that way, but not a big deal)
vibhaa
reviewed
Mar 13, 2019
vibhaa
reviewed
Mar 13, 2019
| double oldBalance = nodeToPaymentChannel[key].balance; | ||
| simtime_t zeroStartTime = nodeToPaymentChannel[key].zeroStartTime; | ||
|
|
||
| if ( ( oldBalance == 0 ) && ( zeroStartTime >= 0) && ( zeroStartTime + _rebalanceTimeReq <= simTime()) ) |
Member
There was a problem hiding this comment.
minor nit: can you change this to simTime > zeroStartTime + _rebalanceTimeReq? (more intuitive that way, but not a big deal)
vibhaa
reviewed
Mar 13, 2019
vibhaa
requested changes
Mar 13, 2019
vibhaa
left a comment
vibhaa
left a comment
Member
There was a problem hiding this comment.
One major bug - balance should be added proportional to total capacity not current balance. Others are minor. Can you please fix as early as possible? Thanks!
karuan
commented
Mar 13, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.