Repository navigation
fix(security): export filename sanitiser, dead tcpServer config, HttpOnly WAR cookie (#2348) - #2386
Merged
Merged
Conversation
…e follow-ups (#2348) Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…pOnly WAR cookie (#2348) Adds ContentDispositions (quoted ASCII filename plus RFC 5987 filename*) and uses it where the name comes from a request parameter (chart, xls/csv/pdf export, admin download). Removes the unread db.tcpServer=-tcpAllowOthers context-param and declares the WAR session cookie HttpOnly. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Semantic model diffSemantic model diffNo model changes and no broken references. saiku#1434 · reproduce locally with |
juanresendiz813
approved these changes
Nov 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The small, safe items from the #2348 hygiene list. Header injection was already blocked by the servlet containers; this removes filename mangling, a misleading dead config and a WAR cookie gap.
Done
ContentDispositions(strips everything outside letters/digits/. _ -/space, collapses whitespace, trims leading dots, caps length, emits quoted ASCIIfilenameplus RFC 5987filename*). Used where the name is request-controlled:ExporterResourcechart export,Query2Resourcexls/csv/pdf exports,AdminResourcedownload. The other call sites build the name from server config (SaikuProperties), so they are untouched (see below).db.tcpServer=-tcpAllowOtherscontext-param fromweb.xml(repo grep found no reader).web.xmldeclares<cookie-config><http-only>true</http-only>.Left as findings (not done here)
sqlin the explain response behind a policy/role: needs a decision on the policy shape (admin-only vs a new data-return knob). Note thesqlleak across users itself is [security] Explain endpoint SQL capture is a global, un-thread-filtered log appender — returns another concurrent user's SQL (filter values, role predicates, physical names) #2328 (PR fix(security): scope explain SQL capture to the explaining execution (#2328) #2372); LLM egress is [security] Explain endpoint sends cell values and member captions to the LLM vendor even under SAIKU_AI_LLM_EGRESS=schema-only #2329 (PR fix(security): honour the LLM egress policy in explain narratives (#2329) #2379).QueryResourceandAiQueryResourcecall sites and the drillthrough/config-named exports inQuery2Resourceuse server-config names, so they carry no request input; could be migrated for consistency.allowedTools,requireConfirmation, annotation handling, pending step plus confirm endpoint, audit): new admin-API fields, a new client protocol step and a default-behaviour change for existing MCP operators. Needs a design decision.setSecureRequestOnlyin the launcher, documentingsaiku.session.cookie.secure: these change session behaviour for every operator (the 7-day idle default is deliberate local-dev UX), so they need a maintainer decision.Overlap: #2328 and #2329 touch the explain code; this PR does not.
Test plan
ContentDispositionsTest(7 cases: sanitising/quoting incl. CR/LF, traversal, non-ASCII, blank default, length cap):mvn -pl saiku-core/saiku-web -am test -Dtest=ContentDispositionsTestQuery2Resource*/ExporterResource*/AdminResource*unit tests in saiku-web still passnode acceptance/2348/check.mjsfails on base, passes on headCloses #2348
🤖 Generated with Claude Code