Repository navigation
docs(security): document OLAP query guardrails in operator-hardening (#1914) - #2377
Merged
Merged
Conversation
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
3 tasks done
juanresendiz813
left a comment
Contributor
There was a problem hiding this comment.
Every value in the new section checks out against the code (QueryGuardrails, mondrian.properties, the Dockerfile and dist/run.*), so this is close. It now conflicts with development and needs a rebase; a few wording fixes can go in the same push.
Blocking
blocking· Merge conflict ·docs/operator-hardening.md
Since #2389 landed, GitHub reports this as conflicting: both append a section at the end of the file. Please rebase and keep both sections. (#2385 and #2393 append there too, so whichever lands later will need the same keep-both rebase.)
Non-blocking
non-blocking· Accuracy ·docs/operator-hardening.md:145-146and:152: "Every execute path applies server-side limits so a single authenticated request cannot run unbounded" and the rawDRILLTHROUGHclaim over-claim until #2327 is actually fixed (#2366 as submitted doesn't close it yet). Either land this after a reworked #2366, or soften to "apply server-side limits intended to ...".non-blocking· Accuracy ·:161-163"restarts the process": the flag makes the JVM exit; a restart needs a restart policy or orchestrator (the Dockerfile's own comment says so,Dockerfile:86-87), and withrun.shnothing restarts it. Also worth noting that-e JAVA_TOOL_OPTIONS=...replaces the image's flags, so operators should useJAVA_OPTS(Dockerfile:82-84).non-blocking·:158-159"prefer raising thesaiku.olap.*ceilings above first": for timeouts both layers have to be raised; say so.praise·Refs #1914rather thanCloses, and every number traceable to source.
🤖 Generated with Claude Code
juanresendiz813
approved these changes
Nov 18, 2026
juanresendiz813
left a comment
Contributor
There was a problem hiding this comment.
Approving. The wording notes from my review are on #1914. Before it can merge it needs a rebase; keep both sections in docs/operator-hardening.md.
🤖 Generated with Claude Code
Conflict in docs/operator-hardening.md: development appended the pass-through credentials section (#2341) at the same spot. Kept both sections, development's first, separated by horizontal rules. Signed-off-by: Juan Resendiz <50384386+juanresendiz813@users.noreply.github.com>
Resolve docs/operator-hardening.md: keep both sections, development's reverse-proxy lockout section first. Signed-off-by: Juan Resendiz <50384386+juanresendiz813@users.noreply.github.com>
Signed-off-by: Juan Resendiz <50384386+juanresendiz813@users.noreply.github.com>
PR acceptance metricAcceptance rate: 85.8% — 424 merged / 494 decided PRs (6 still open, excluded from the denominator).
Generated by |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The #1914 fix (PR #2082, merged) added
saiku.olap.query.timeout.seconds,saiku.olap.max.rowsandsaiku.olap.arrow.max.bytesplus non-zero Mondrian defaults and OOM-exit flags, but they are only listed in SECURITY.md. This documents them indocs/operator-hardening.mdas the issue asked. Docs only; values verified againstQueryGuardrails,mondrian.properties,Dockerfileanddist/run.*.Refs #1914 (the code fix already shipped, so this PR does not use a closing keyword and ships no acceptance spec).
Test plan
🤖 Generated with Claude Code