Skip to content

docs(security): document OLAP query guardrails in operator-hardening (#1914) - #2377

Merged
juanresendiz813 merged 4 commits into
developmentfrom
docs/1914-query-guardrails
Nov 19, 2026
Merged

juanresendiz813 merged 4 commits into
developmentfrom
docs/1914-query-guardrails

Conversation

@buggtb

@buggtb buggtb commented Nov 12, 2026

Copy link
Copy Markdown
Contributor

Summary

The #1914 fix (PR #2082, merged) added saiku.olap.query.timeout.seconds, saiku.olap.max.rows and saiku.olap.arrow.max.bytes plus non-zero Mondrian defaults and OOM-exit flags, but they are only listed in SECURITY.md. This documents them in docs/operator-hardening.md as the issue asked. Docs only; values verified against QueryGuardrails, mondrian.properties, Dockerfile and dist/run.*.

Refs #1914 (the code fix already shipped, so this PR does not use a closing keyword and ships no acceptance spec).

Test plan

  • Cross-checked each default against source on development
  • CI

🤖 Generated with Claude Code

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
@buggtb buggtb added the security Created by Hive for agent-filed issue provenance label Nov 12, 2026
@github-actions github-actions Bot added docs risk/low Change risk tier: low (see docs/risk-tiers.md) labels Nov 12, 2026

@juanresendiz813 juanresendiz813 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Every value in the new section checks out against the code (QueryGuardrails, mondrian.properties, the Dockerfile and dist/run.*), so this is close. It now conflicts with development and needs a rebase; a few wording fixes can go in the same push.

Blocking

  1. blocking · Merge conflict · docs/operator-hardening.md
    Since #2389 landed, GitHub reports this as conflicting: both append a section at the end of the file. Please rebase and keep both sections. (#2385 and #2393 append there too, so whichever lands later will need the same keep-both rebase.)

Non-blocking

  • non-blocking · Accuracy · docs/operator-hardening.md:145-146 and :152: "Every execute path applies server-side limits so a single authenticated request cannot run unbounded" and the raw DRILLTHROUGH claim over-claim until #2327 is actually fixed (#2366 as submitted doesn't close it yet). Either land this after a reworked #2366, or soften to "apply server-side limits intended to ...".
  • non-blocking · Accuracy · :161-163 "restarts the process": the flag makes the JVM exit; a restart needs a restart policy or orchestrator (the Dockerfile's own comment says so, Dockerfile:86-87), and with run.sh nothing restarts it. Also worth noting that -e JAVA_TOOL_OPTIONS=... replaces the image's flags, so operators should use JAVA_OPTS (Dockerfile:82-84).
  • non-blocking · :158-159 "prefer raising the saiku.olap.* ceilings above first": for timeouts both layers have to be raised; say so.
  • praise · Refs #1914 rather than Closes, and every number traceable to source.

🤖 Generated with Claude Code

@juanresendiz813 juanresendiz813 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving. The wording notes from my review are on #1914. Before it can merge it needs a rebase; keep both sections in docs/operator-hardening.md.

🤖 Generated with Claude Code

Conflict in docs/operator-hardening.md: development appended the
pass-through credentials section (#2341) at the same spot. Kept both
sections, development's first, separated by horizontal rules.

Signed-off-by: Juan Resendiz <50384386+juanresendiz813@users.noreply.github.com>
Resolve docs/operator-hardening.md: keep both sections, development's
reverse-proxy lockout section first.

Signed-off-by: Juan Resendiz <50384386+juanresendiz813@users.noreply.github.com>
Signed-off-by: Juan Resendiz <50384386+juanresendiz813@users.noreply.github.com>
@juanresendiz813
juanresendiz813 added this pull request to the merge queue Nov 18, 2026
Merged via the queue into development with commit 0bf9ea4 Nov 19, 2026
24 checks passed
@github-actions

Copy link
Copy Markdown

PR acceptance metric

Acceptance rate: 85.8% — 424 merged / 494 decided PRs (6 still open, excluded from the denominator).

Metric Value
Acceptance rate 85.8%
Accepted / rejected / open 424 / 70 / 6
Median time to first review (merged) 125.1 h
Median time to merge (merged) 14.0 h
Median time open (decided) 18.3 h
Mean review rounds on merged PRs 1.3
Authors with at least one merged PR 8
Author Merged Rejected Acceptance
buggtb 212 19 91.8%
app/dependabot 98 41 70.5%
juanresendiz813 94 1 98.9%
app/spicule-hive 8 1 88.9%
spicule-hive-bot 8 1 88.9%
oiacub1 2 0 100.0%
k-jm 1 3 25.0%
Prithvi1994 1 0 100.0%
laborima 0 3 0.0%
rezamuliawijaya 0 1 0.0%

Generated by scripts/pr-metrics.mjs — see docs/metrics.md.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs risk/low Change risk tier: low (see docs/risk-tiers.md) security Created by Hive for agent-filed issue provenance

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants