Repository navigation
feat: visible verdicts, clearer messages, optional shared head build - #2
Merged
Merged
Conversation
…head build - verdict output + report-only output on all three reusable workflows, one verdict line in the job summary and a titled annotation; job names unchanged - comment.yml: opt-in sticky PR comment, the only job with pull-requests: write, no checkout of caller code, skipped on forks - base-check wording: "not green on the PR build yet" vs "passes on the base branch" - opt-in share-build: run-specs uploads the head build, base-check reuses it (same run, falls back) - selftest: red-on-head, green-on-base and shared-build fixture cases, and the comment job Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Acceptance self-test (fixture)
Updated for commit aa615e2, workflow run. This comment is edited in place, never repeated. |
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
convention,run-specsandbase-checkeach exposeverdict(pass,red-on-base-green-on-head,fail,passes-on-base,not-run,skipped) andreport-only(true/false) asworkflow_calloutputs, write one verdict heading to the job summary, and emit a::notice/::warningtitledacceptance <workflow>: <verdict>. Job results and names are unchanged;mode: reportsemantics are unchanged.comment.yml(opt in). One sticky PR comment with a three-row table in plain words, found by a hidden marker and by the Actions bot as author, edited in place on every push.docs/spec-format.mdupdated.share-build.run-specs(share-build: true,share-build-paths) uploads the head build as a tar artifact;base-check(share-build: true, orderedneeds:after it) unpacks it instead of rebuilding head. Same run only, 1 day retention, never on forks, falls back to building. Default off. Trade-offs indocs/adopting.md.Why
The inertia pilot (report mode) showed red specs hiding behind green checks, a message that blamed "the PR build too" when the feature was simply not done, no result at a glance, and the head being built twice.
Opt-in for a caller (existing callers are unaffected: every new input defaults off, new outputs are additive)
Optional build reuse:
share-build: true+share-build-paths: <outputs>onrun-specs;needs: [specs]+share-build: trueonbase-check.Verification
node --test "scripts/*.test.mjs": 123 tests pass (new: verdict mapping, caller verdicts, comment text and marker, share-build pack/unpack and path refusal, new wording, guard tests).pull-requests: writeis now allowed in exactly two places, the job-level block ofcomment.ymland of the selftest job that calls it, never at top level, and never mentioned in the three workflows that execute PR code. A new test assertscomment.ymlhas a single checkout, of this repository's scripts (not the caller's), no build/start inputs, no secrets, and usesgithub.tokenonce. SHA pinning, pull_request-only, env-not-interpolated tests unchanged and green.selftestend to end on the fixture, green. Averdictsjob asserts: consumerrun-specs=pass; red fixturerun-specs=failwhile its job result issuccess(the report-mode problem, now visible);red-base-check=fail;green-on-base=passes-on-base; consumerbase-check=red-on-base-green-on-head(new spec 3 against a new/api/gadgetsroute);build-reused=true(the share-build path really ran: "Head build reused from run-specs"). Note base-check cases reportskippedon later PRs that do not touch their fixture specs.Risk
Low. Additive outputs and a summary heading; one new optional workflow; share-build and comment are off unless opted in. The only new write scope is
pull-requests: writeon the caller'scommentjob, which runs none of the PR's code.Unverified
uses:ofcomment.ymlfrom another repo (selftest uses the local./form), including thatjob.workflow_sharesolves there.base-checkafterrun-specs, so measure on a real app before adopting.🤖 Generated with Claude Code