[ENH] Sphinx's exclude_patterns as ignore patterns#135
Open
maxdup wants to merge 2 commits intosphinx-doc:mainfrom
Open
[ENH] Sphinx's exclude_patterns as ignore patterns#135maxdup wants to merge 2 commits intosphinx-doc:mainfrom
exclude_patterns as ignore patterns#135maxdup wants to merge 2 commits intosphinx-doc:mainfrom
Conversation
|
Thanks for submitting your first pull request! You are awesome! 🤗 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi :) This is an implementation for the feature requested in issue #131
This fork enables sphinx-autobuild's ignore system to leverage sphinx's
conf.py.Sphinx's
exclude_patternsconfiguration is now taken into account when determining what files to ignore.P.S: I know my try statement looks a little paranoid but I feel it's adequate given the circumstances.
Anyway, let me know your thoughts.
P.P.S: Sorry I couldn't run the linter ¯_(ツ)_/¯ (but I did run the code through Black)