Repository navigation
Conversation
Documentation build overview
|
ANO3457
force-pushed
the
fix/flaskqref-path-order-33
branch
from
October 24, 2026 10:51
14a8683 to
1a27459
Compare
Collaborator
|
@ANO3457 I won't review any PR that has malicious payloads in the commit history. Closing. You're welcome to open a clean PR. |
This was referenced Oct 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #33, following the maintainer's request for matching
qrefflask/autoflaskordering and a reproducible test.qrefflaskcurrently collects rows into resource-name buckets and sorts the bucket names, overriding the endpoint path order produced byAutoflaskBase. Simply preserving bucket insertion order still fails when the same resource has paths on both sides of another resource.This keeps the base directive's row order for
:order: pathand suppresses repeated resource labels/descriptions only within consecutive runs. Without:order: path, a stable resource-name sort preserves the historical alphabetical grouping and within-resource order. The documented option and a changelog entry are included.The regression builds actual Sphinx HTML documentation from a Flask application whose registration, resource-name, and path orders differ. It compares quick-reference rows to the detailed API signatures, checks interleaved resources, repeated descriptions, unnamed resources, and unchanged default behavior. Before the fix: 2 failed, 2 passed. After the fix, the local full suite passes (15 passed, 1 Python-3.10-only wheel-smoke skip).
Validation of product head
14a8683e4b5e246afa9db4190b7374b621cc3b2e, based on32c21562d85d3accf4f06a0a88a1b24f92089ce5:tox r -e py310: 16 passed, 0 skipped, including the wheel smoke test; documentation-Wpassed.tox r -e py313: 15 passed, 1 Python-3.10-only wheel smoke skip; documentation-Wpassed.This is separate from #154 (parallel-read metadata) and #153 (routing-table labels). No changes from those PRs are included.
AI disclosure: OpenAI Codex investigated, implemented, reviewed the diff, and executed the checks under the account owner's authorization. No personal human review is claimed.