Skip to content

Conversation

@google-labs-jules
Copy link
Contributor

Diagnosed and fixed flaky tests in implants/lib/eldritch/src/sys/exec_impl.rs.
The tests test_sys_exec_disown_no_defunct and test_sys_exec_disown_linux were failing due to race conditions when accessing the process table to check for zombie processes.
Solution:

  • Added lazy_static dev-dependency.
  • Implemented a static Mutex to serialize execution of these specific tests.
  • Verified the fix by running the tests 50 times without failure.

PR created automatically by Jules for task 16724354426563609186 started by @KCarretto

Introduced a mutex to serialize tests that check for zombie processes (`test_sys_exec_disown_no_defunct` and `test_sys_exec_disown_linux`).
These tests inspect the global process table and were failing intermittently when run in parallel with other tests spawning processes.
Added `lazy_static` dependency to support the static mutex.
@google-labs-jules
Copy link
Contributor Author

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@github-actions
Copy link
Contributor

github-actions bot commented Jan 6, 2026

Summary

Tests 📝 Passed ✅ Failed ❌ Skipped ⏭️ Other ❓ Flaky 🍂 Duration ⏱️
2938    ±0 2938    ±0 0    ±0 0    ±0 0    ±0 0    ±0 1ms    ±0

Previous Results

Build 🏗️ Result 🧪 Tests 📝 Passed ✅ Failed ❌ Skipped ⏭️ Other ❓ Flaky 🍂 Duration ⏱️
#338 2938 2938 0 0 0 0 30.4s

Insights

Average Tests per Run Total Flaky Tests Total Failed Slowest Test (p95)
2938 0 0 43.7s

Slowest Tests

Test 📝 Results 📊 Duration (avg) ⏱️ Duration (p95) ⏱️
eldritch: random::string_impl::tests::test_string_uniform 3 42.4s 43.7s
eldritch: random::string_impl::tests::test_string_uniform 3 42.4s 43.7s
eldritch: random::string_impl::tests::test_string_uniform 3 42.4s 43.7s
eldritch: process::info_impl::tests::test_info_default 3 3.1s 8.8s
eldritch: process::info_impl::tests::test_info_default 3 3.1s 8.8s
eldritch: process::info_impl::tests::test_info_default 3 3.1s 8.8s
eldritch: pivot::port_scan_impl::tests::test_portscan_return_type_starlark_dict_from_interpreter 3 2.8s 8.3s
eldritch: pivot::port_scan_impl::tests::test_portscan_return_type_starlark_dict_from_interpreter 3 2.8s 8.3s
eldritch: pivot::port_scan_impl::tests::test_portscan_return_type_starlark_dict_from_interpreter 3 2.8s 8.3s
eldritch: pivot::ssh_copy_impl::tests::test_pivot_ssh_copy 3 4.1s 8.3s

🎉 No failed tests in this run. | 🍂 No flaky tests in this run.

Github Test Reporter by CTRF 💚

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant