Skip to content

Conversation

@hulto
Copy link
Collaborator

@hulto hulto commented Jan 1, 2026

Updated the test data generation to use HTTP1, GRPC, and DNS transports instead of all beacons being TRANSPORT_UNSPECIFIED. The beacons now cycle through the three transport types to provide more realistic test data.

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Updated the test data generation to use HTTP1, GRPC, and DNS transports
instead of all beacons being TRANSPORT_UNSPECIFIED. The beacons now cycle
through the three transport types to provide more realistic test data.
@hulto hulto marked this pull request as ready for review January 1, 2026 18:10
@cmp5987 cmp5987 self-requested a review January 1, 2026 18:19
Copy link
Collaborator

@cmp5987 cmp5987 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM --- Thanks for expanding the test data :)

@github-actions
Copy link

github-actions bot commented Jan 1, 2026

Summary

Tests 📝 Passed ✅ Failed ❌ Skipped ⏭️ Other ❓ Flaky 🍂 Duration ⏱️
2744    ±0 2744    ±0 0    ±0 0    ±0 0    ±0 0    ±0 1ms    ±0

Previous Results

Build 🏗️ Result 🧪 Tests 📝 Passed ✅ Failed ❌ Skipped ⏭️ Other ❓ Flaky 🍂 Duration ⏱️
#150 2744 2744 0 0 0 0 26.6s

Insights

Average Tests per Run Total Flaky Tests Total Failed Slowest Test (p95)
2744 0 0 43.2s

Slowest Tests

Test 📝 Results 📊 Duration (avg) ⏱️ Duration (p95) ⏱️
eldritch: random::string_impl::tests::test_string_uniform 3 39.4s 43.2s
eldritch: random::string_impl::tests::test_string_uniform 3 39.4s 43.2s
eldritch: random::string_impl::tests::test_string_uniform 3 39.4s 43.2s
eldritch: random::int_impl::tests::test_random_int_uniform_average 3 3.8s 7.8s
eldritch: random::int_impl::tests::test_random_int_uniform_average 3 3.8s 7.8s
eldritch: random::int_impl::tests::test_random_int_uniform_average 3 3.8s 7.8s
eldritch: random::int_impl::tests::test_random_int_uniform_chi_square 3 3.8s 7.7s
eldritch: random::int_impl::tests::test_random_int_uniform_chi_square 3 3.8s 7.7s
eldritch: random::int_impl::tests::test_random_int_uniform_chi_square 3 3.8s 7.7s
eldritch: random::string_impl::tests::test_string_length 3 5.9s 7.7s

🎉 No failed tests in this run. | 🍂 No flaky tests in this run.

Github Test Reporter by CTRF 💚

🔄 This comment has been updated

@hulto hulto merged commit f22e181 into main Jan 1, 2026
11 of 12 checks passed
@hulto hulto deleted the claude/add-transport-types-test-data-naZn9 branch January 1, 2026 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants