Skip to content

docs(claude): collect the three names that are configuration - #38

Merged
kewang merged 1 commit into
masterfrom
docs/ci-job-name-trap
Aug 4, 2026
Merged

docs(claude): collect the three names that are configuration#38
kewang merged 1 commit into
masterfrom
docs/ci-job-name-trap

Conversation

@kewang

@kewang kewang commented Aug 4, 2026

Copy link
Copy Markdown
Collaborator

Documents a trap created by enabling branch protection: ci.yml's three job names are now pinned as required status checks, so renaming a job leaves PRs pending forever on a check that never reports — which reads like CI being down rather than a config error.

That is the third instance of the same shape in this repo, so all three are collected into one table at the top of CLAUDE.md instead of staying scattered:

Name Referenced by Rename does
ci.yml job names branch protection PRs pend forever
npm-publish.yml filename npm trusted publisher fails at auth, no cause named
action.yml build chain nothing — the absence is the bug outputs set, files empty

Also records why enforce_admins is deliberately off: the release skill pushes the npm version commit straight to master, and a locally-created commit can never have passed a required check, so enforcing admins would break /release.

Verified the three job names match across all three places (ci.yml, CLAUDE.md, branch protection).

Docs only — no spec under openspec/specs/ touched. Also serves as the first live test of the new branch protection.

Branch protection on master now pins ci.yml's three job names as required status
checks, so renaming a job leaves PRs pending forever on a check that will never
report — reads like CI is down, not like a config error. That is the third instance
of the same shape, alongside npm-publish.yml's filename (registered with npm) and
action.yml's build chain (outputs stay populated while the files are empty).

Collect all three in one table at the top rather than leaving them scattered, and
record why enforce_admins is deliberately off: the release skill pushes the
npm version commit straight to master, and a locally-created commit can never have
passed a required check, so enforcing admins would break /release.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01PgfFLCcVjPxZJmMspbY4Bu
@kewang
kewang merged commit 346cd6a into master Aug 4, 2026
3 checks passed
@kewang
kewang deleted the docs/ci-job-name-trap branch August 4, 2026 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant