[WIP] Do not Merge, Build image use only.#246
[WIP] Do not Merge, Build image use only.#246HigashikataZhangsuke wants to merge 2 commits intospectro-masterfrom
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: HigashikataZhangsuke The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
There was a problem hiding this comment.
- GO-2025-3754
- Module: github.com/cloudflare/circl
- Found in: v1.3.7
- Fixed in: v1.6.1
- Example Traces:
1. cmd/clusterctl/internal/test/fake_github.go:24:2: test.init calls github.init, which eventually calls ed448.init
2. cmd/clusterctl/internal/test/fake_github.go:24:2: test.init calls github.init, which eventually calls ed25519.init
3. cmd/clusterctl/internal/test/fake_github.go:24:2: test.init calls github.init, which eventually calls x448.init
4. cmd/clusterctl/internal/test/fake_github.go:24:2: test.init calls github.init, which eventually calls x25519.init
5. cmd/clusterctl/internal/test/fake_github.go:24:2: test.init calls github.init, which eventually calls ed25519.init
Please review these findings and fix the issues before merging.
There was a problem hiding this comment.
- G115: integer overflow conversion int64 -> int32, Severity: HIGH
-
- File: /home/runner/work/bulwark/bulwark/target-repo/internal/controllers/cluster/cluster_controller_status.go:107:63
-
- File: /home/runner/work/bulwark/bulwark/target-repo/internal/controllers/cluster/cluster_controller_status.go:104:70
-
- File: /home/runner/work/bulwark/bulwark/target-repo/internal/contract/types.go:129:22
-
- File: /home/runner/work/bulwark/bulwark/target-repo/internal/test/envtest/environment.go:89:47
-
- File: /home/runner/work/bulwark/bulwark/target-repo/internal/controllers/machineset/machineset_controller_status.go:189:26
-
- File: /home/runner/work/bulwark/bulwark/target-repo/internal/controllers/machineset/machineset_controller_status.go:123:26
-
- File: /home/runner/work/bulwark/bulwark/target-repo/internal/controllers/machineset/machineset_controller.go:1207:37
-
- File: /home/runner/work/bulwark/bulwark/target-repo/internal/controllers/machineset/machineset_controller.go:1206:33
-
- File: /home/runner/work/bulwark/bulwark/target-repo/internal/controllers/machineset/machineset_controller.go:1205:40
-
- File: /home/runner/work/bulwark/bulwark/target-repo/internal/controllers/machineset/machineset_controller.go:1204:28
-
- File: /home/runner/work/bulwark/bulwark/target-repo/internal/controllers/machinehealthcheck/machinehealthcheck_controller.go:690:26
-
- File: /home/runner/work/bulwark/bulwark/target-repo/internal/controllers/machinehealthcheck/machinehealthcheck_controller.go:678:27
-
- File: /home/runner/work/bulwark/bulwark/target-repo/internal/controllers/machinehealthcheck/machinehealthcheck_controller.go:253:33
-
- File: /home/runner/work/bulwark/bulwark/target-repo/internal/controllers/machinehealthcheck/machinehealthcheck_controller.go:238:35
-
- File: /home/runner/work/bulwark/bulwark/target-repo/internal/controllers/machinedeployment/mdutil/util.go:726:14
- ... (truncated), run gosec locally to capture all failure for the rule G115
-
- G404: Use of weak random number generator (math/rand or math/rand/v2 instead of crypto/rand), Severity: HIGH
-
- File: /home/runner/work/bulwark/bulwark/target-repo/util/util.go:61:8
-
- File: /home/runner/work/bulwark/bulwark/target-repo/util/conversion/conversion.go:160:18
-
- File: /home/runner/work/bulwark/bulwark/target-repo/test/infrastructure/inmemory/internal/controllers/inmemorymachine_controller.go:616:43
-
- File: /home/runner/work/bulwark/bulwark/target-repo/test/infrastructure/inmemory/internal/controllers/inmemorymachine_controller.go:478:33
-
- File: /home/runner/work/bulwark/bulwark/target-repo/test/infrastructure/inmemory/internal/controllers/inmemorymachine_controller.go:468:40
-
- File: /home/runner/work/bulwark/bulwark/target-repo/test/infrastructure/inmemory/internal/controllers/inmemorymachine_controller.go:411:43
-
- File: /home/runner/work/bulwark/bulwark/target-repo/test/infrastructure/inmemory/internal/controllers/inmemorymachine_controller.go:307:43
-
- File: /home/runner/work/bulwark/bulwark/target-repo/test/infrastructure/inmemory/internal/controllers/inmemorymachine_controller.go:269:43
-
- File: /home/runner/work/bulwark/bulwark/target-repo/test/infrastructure/docker/exp/internal/controllers/dockermachinepool_controller_phases.go:95:18
-
- File: /home/runner/work/bulwark/bulwark/target-repo/test/framework/machinedeployment_helpers.go:379:100
-
- File: /home/runner/work/bulwark/bulwark/target-repo/test/framework/machinedeployment_helpers.go:378:96
-
- File: /home/runner/work/bulwark/bulwark/target-repo/test/framework/machinedeployment_helpers.go:377:93
-
- File: /home/runner/work/bulwark/bulwark/target-repo/test/e2e/clusterclass_rollout.go:226:46
-
- File: /home/runner/work/bulwark/bulwark/target-repo/test/e2e/clusterclass_rollout.go:225:81
-
- File: /home/runner/work/bulwark/bulwark/target-repo/test/e2e/clusterclass_rollout.go:224:77
- ... (truncated), run gosec locally to capture all failure for the rule G404
-
- G402: TLS InsecureSkipVerify set true., Severity: HIGH
-
- File: /home/runner/work/bulwark/bulwark/target-repo/test/infrastructure/inmemory/pkg/server/mux.go:466:24
-
- File: /home/runner/work/bulwark/bulwark/target-repo/controlplane/kubeadm/internal/workload_cluster.go:469:62
-
Please review these findings and fix the issues before merging.
|
Done in PEM-10055 |
Do not Merge, Build image use only.