Closed
Conversation
…tart-update 📖 Add capz identity instructions to quick start
…eries 🐛 clusterctl: use newest release series of same contract
…uickstart 📖 Add back base64 encoded CAPZ quickstart variables for creds
…ultValidateTest 🐛 fix DefaultValidateTest ensuring old object gets defaulted too
Signed-off-by: Stefan Büringer buringerst@vmware.com Co-authored-by: Jack Francis <jack.francis@microsoft.com>
Signed-off-by: Naadir Jeewa <jeewan@vmware.com>
…-16-6 🌱 Bump golang to 1.16.6
This gets rid of calls out to the docker CLI with parsing of its output to perform docker management. Calls now use the docker SDK directly. This is the first step towards making the CAPD more testable and potentially able to use other CRIs. Ideally, long term, we will want to refactor the code to move all runtime interaction into one or more interfaces that would give us the option for swapping out implementations. We can also then set up better unit testing for all code paths to make sure the interacting code is correct, regardless of the implementation of the runtime interaction. Signed-off-by: Sean McGinnis <sean.mcginnis@gmail.com>
…ject-debian-script 🌱 test/framework: improve the way we inject the ci-artifacts script
✨ Use docker API instead of exec'ing docker cmds
Signed-off-by: Stefan Büringer buringerst@vmware.com
…ickstart-to-1.21.2 🌱 Upgrade quickstart and e2e tests to Kubernetes v1.21.2
Backup writes objects from target cluster and namespace to disc in configured directory. Restore rebuilds the object graph from configured directory files. Both require a configured directory to execute command. Enables reboot / reload workflow. Adds backup and restore tests.
…e-feature ✨ Implements Backup and Restore for objectMover
Signed-off-by: Stefan Büringer buringerst@vmware.com
…r-class-proposal-nits 📖 Add detail about ClusterClass reconciliation in ClusterClass proposal
Admission Review was previously set to only accept v1beta1 objects given that Controller Runtime didn't support v1 (even though the two revisions are effectively the same). This change adds support for both within our manifests. Signed-off-by: Vince Prignano <vincepri@vmware.com>
…a1-admissions 🐛 Webhook registration should accept both v1 and v1beta1 admissions
📖 Document test matrix in the book
🐛 validate namespace of MHC remediation template
📖 Fix incorrect indents
…led-errors 🐛 fix unhandled errors
image pull Signed-off-by: Stefan Büringer buringerst@vmware.com
`AvailableCondition` and `ReadyCondition`.
✨ Adds `AvailableCondition` and `ReadyCondition` Conditions to MachineDeployment
Signed-off-by: Stefan Büringer buringerst@vmware.com
…rclass-webhook-to-envtest 🌱 envtest: enable ClusterClass webhook
…print.HasMachineDeployments 🐛 Fix blueprint.HasMachineDeployments
…sion Signed-off-by: Vince Prignano <vincepri@vmware.com>
Signed-off-by: Vince Prignano <vincepri@vmware.com>
…lingupdate 🐛 KubeadmControlPlane rolloutstrategy should be defaulted in openapi
…class-create-check-package 🌱 Create internal/check package for ClusterClass
📖 Update testing docs
…erctl-upgrade-to-v0.3.23 🌱 bump clusterctl upgrade test to CAPI v0.3.23
…class-create-contract-package 🌱 create internal/contract package for ClusterClass
…mplate-mutable-apiversion 🐛 KubeadmControlPlane should allow to change the machineTemplate's apiVersion
…th-kind 🌱 Enable envtest with kind
…te-clusterclass-with-rebase 📖 Add validation for ClusterClass compatibility
|
Hi @sadysnaat. Thanks for your PR. I'm waiting for a spectrocloud member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: sadysnaat The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RollOut fix
relax webhook v1alpha4
wait for volume detach after node drain/already in v1alpha4
sort mhc status targets to avoid status keep changing/already in v1alpha4
do not wrap node delete error because caller is checking error type
Fixed By 🐛 Node deletion should check the cause of the error kubernetes-sigs/cluster-api#3966
include machines in deleting status when calculate machineset replicas/already in v1alpha4
commit 2acad2a
Author: Deepak Sharma deepak@spectrocloud.com
Date: Wed Sep 9 22:14:51 2020 +0530
already present in v1alpha4
add finalizer to kcp in first reconcile to avoid race condition with delete already in v1alpah4
fix FailureDomains doc v1alpah2 doc change won't include