feat: Patient-Profile-Page - #23
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implementasi AUTH-04 Patient Profile Page, pasien dapat melihat dan mengupdate data profil mereka (nama, nomor telepon, BPJS, tempat lahir, tanggal lahir, gender). Profile data di-fetch langsung dari
GET /patients/meindependent dari AuthContext, sehingga selalu menampilkan data terbaru setelah update.Jira Ticket
Ticket:
Type of Change
Changes Made
src/types/patient.ts- type definitions untuk PatientProfile dan PatientProfileUpdatePayload, independent dari types/auth.tssrc/services/patientService.ts- abstraksi HTTP call untuk GET /patients/me dan PATCH /patients/mesrc/pages/ProfilePage.tsx- profile page dengan fetch on mount, partial update form, per-field error handling untuk 422, success message setelah update berhasil, dan LogoutButton di headersrc/App.tsx- tambah route /profile di bawah ProtectedRoutesrc/tests/pages/ProfilePage.test.tsx- 7 unit testsHow to Test
/profilenpm run testScreenshots (if applicable)
Checklist
Notes for Reviewer
Profile data di-fetch dari GET /patients/me secara independent bukan dari user.profile di AuthContext. Ini intentional agar data selalu up-to-date setelah PATCH tanpa perlu update AuthContext.