Skip to content

chore: migrate pnpm config from package.json to pnpm-workspace.yaml#2934

Merged
alx-xo merged 4 commits into
mainfrom
alexm/age-2436-chore-migrate-pnpm-overrides
May 21, 2026
Merged

chore: migrate pnpm config from package.json to pnpm-workspace.yaml#2934
alx-xo merged 4 commits into
mainfrom
alexm/age-2436-chore-migrate-pnpm-overrides

Conversation

@alx-xo
Copy link
Copy Markdown
Contributor

@alx-xo alx-xo commented May 19, 2026

Summary

pnpm v10 no longer reads the "pnpm" field in package.json, emitting noisy [WARN] on every run (shows in agent runs as well)

  • overrides migrated recharts to pnpm-workspace.yaml
  • ignoredBuiltDependencies was migrated to pnpm-workspace.yaml
  • Removed override for react-is, and removed unused dep react-is as wasn't used

Root cause

pnpm v10 deprecated the package.json#pnpm config block in favour of pnpm-workspace.yaml. The existing glob override was already in the right place; only overrides and ignoredBuiltDependencies needed moving.

Test plan

  • pnpm install runs with no [WARN] about ignored pnpm fields
  • Lock file resolves overrides correctly

pnpm v10 no longer reads the "pnpm" field in package.json, emitting a
[WARN] on every install. Move overrides and ignoredBuiltDependencies
into pnpm-workspace.yaml where pnpm v10 expects them.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@vercel
Copy link
Copy Markdown

vercel Bot commented May 19, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
gram-docs-redirect Ready Ready Preview, Comment May 20, 2026 6:01pm

Request Review

@alx-xo alx-xo requested a review from a team as a code owner May 19, 2026 22:25
@alx-xo alx-xo added the dependencies Pull requests that update a dependency file label May 19, 2026
Copy link
Copy Markdown

@claude claude Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claude Code Review

This repository is configured for manual code reviews. Comment @claude review to trigger a review and subscribe this PR to future pushes, or @claude review once for a one-time review.

Tip: disable this comment in your organization's Code Review settings.

@linear-code
Copy link
Copy Markdown

linear-code Bot commented May 19, 2026

AGE-2436

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented May 19, 2026

⚠️ No Changeset found

Latest commit: c4f340e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@alx-xo alx-xo force-pushed the alexm/age-2436-chore-migrate-pnpm-overrides branch from e685e01 to eff1fa0 Compare May 19, 2026 22:27
Copy link
Copy Markdown
Contributor

@disintegrator disintegrator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we confirm that these overrides are still needed before merging?

@alx-xo
Copy link
Copy Markdown
Contributor Author

alx-xo commented May 20, 2026

Good question!

  • "react-is" was not being used at all. Its use case is for tests. Have removed it from overrides and package.json
  • "recharts" is used, but is listed in devDeps as the same version so didn't need to have an override listing

Actually turns out the override for recharts was needed to prevent another dep from resolving Recharts to v3

@alx-xo alx-xo added this pull request to the merge queue May 21, 2026
Merged via the queue into main with commit ffc69fc May 21, 2026
38 checks passed
@alx-xo alx-xo deleted the alexm/age-2436-chore-migrate-pnpm-overrides branch May 21, 2026 02:32
@github-actions github-actions Bot locked and limited conversation to collaborators May 21, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

dependencies Pull requests that update a dependency file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants