chore: migrate pnpm config from package.json to pnpm-workspace.yaml#2934
Conversation
pnpm v10 no longer reads the "pnpm" field in package.json, emitting a [WARN] on every install. Move overrides and ignoredBuiltDependencies into pnpm-workspace.yaml where pnpm v10 expects them. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
Claude Code Review
This repository is configured for manual code reviews. Comment @claude review to trigger a review and subscribe this PR to future pushes, or @claude review once for a one-time review.
Tip: disable this comment in your organization's Code Review settings.
|
e685e01 to
eff1fa0
Compare
disintegrator
left a comment
There was a problem hiding this comment.
Can we confirm that these overrides are still needed before merging?
|
Good question!
Actually turns out the override for recharts was needed to prevent another dep from resolving Recharts to v3 |
Summary
pnpm v10 no longer reads the
"pnpm"field inpackage.json, emitting noisy[WARN]on every run (shows in agent runs as well)overridesmigratedrechartstopnpm-workspace.yamlignoredBuiltDependencieswas migrated topnpm-workspace.yamlreact-is, and removed unused depreact-isas wasn't usedRoot cause
pnpm v10 deprecated the
package.json#pnpmconfig block in favour ofpnpm-workspace.yaml. The existinggloboverride was already in the right place; onlyoverridesandignoredBuiltDependenciesneeded moving.Test plan
pnpm installruns with no[WARN]about ignored pnpm fields