fix(dashboard): restore backfill controls in risk-policy progress sheet#2918
Open
mfbx9da4 wants to merge 2 commits into
Open
fix(dashboard): restore backfill controls in risk-policy progress sheet#2918mfbx9da4 wants to merge 2 commits into
mfbx9da4 wants to merge 2 commits into
Conversation
…sk-policy progress sheet
There was a problem hiding this comment.
Claude Code Review
This repository is configured for manual code reviews. Comment @claude review to trigger a review and subscribe this PR to future pushes, or @claude review once for a one-time review.
Tip: disable this comment in your organization's Code Review settings.
🦋 Changeset detectedLatest commit: 4d74aff The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Collaborator
🚀 Preview Environment (PR #2918)Preview URL: https://pr-2918.dev.getgram.ai
Gram Preview Bot |
Contributor
|
Found 1 test failure on Blacksmith runners: Failure
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The risk-policy progress sheet was meant to ship with two backfill controls:
Backfill last N— Input + button (sends a positivelimit)Backfill all messages— sendslimit=0to drain everythingThey were added in #2889 (`feat(risk): default to recent-N drain; opt-in full backfill`, merged 2026-05-18T12:01Z) and reached prod with sha-b8ed614. They were then inadvertently dropped 45 minutes later when #2855 (`feat(risk): normalize risk_result rule_id + description across scanners`) squash-merged.
Root cause: while merging `origin/main` (which had just received #2889) into the #2855 branch, merge commit `fb4377b02` reported a conflict in `PolicyCenter.tsx`. The resolution kept the branch's pre-#2889 footer, silently restoring the single "Trigger Analysis" button. The branch was squash-merged from that state, so main lost the backfill UI even though the wire format and backend `limit` plumbing remained in place.
The SDK still carries `triggerRiskAnalysisRequestBody.limit?: number` and the backend still accepts `limit=0` for full backfill and any positive integer for bounded — this PR just reconnects the dashboard.
What changed
Test plan