Fix task exit status handling, uniformize process exit method and tests#74
Merged
freekmurze merged 1 commit intospatie:mainfrom Apr 24, 2025
Merged
Fix task exit status handling, uniformize process exit method and tests#74freekmurze merged 1 commit intospatie:mainfrom
freekmurze merged 1 commit intospatie:mainfrom
Conversation
Contributor
Author
|
@freekmurze hi ! Could you take a moment to take a look at this pull request please ? Thanks ! |
Member
|
Thanks! |
|
This pull request is crashing my laravel scheduled tasks due to: posix_kill(getmypid(), SIGKILL); I'm getting errors for queries until I discovered this: I have opened a discussion - #76 |
Member
|
@jchambon-equativ could you take a look at this? |
Contributor
Author
|
@freekmurze: @sadiqsalau closed the conversation because the problem was elsewhere. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In this commit I mainly updated the $status handling in Task.php because the same variable was used for 2 purposes.
I also added the thread exit with posix when enabled.
And because the pest --filter option still executes all the test which aren't wrapped in a callable I managed to refactor the test file to fix this.