Conversation
sparsick
force-pushed
the
windows-support
branch
2 times, most recently
from
4083dfc to
40e189f
Compare
sparsick
force-pushed
the
windows-support
branch
from
40e189f to
6efab9e
Compare
sparsick
force-pushed
the
windows-support
branch
from
b5d84a5 to
513c1d8
Compare
sparsick
force-pushed
the
windows-support
branch
from
11524dd to
3e14f9b
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #86 +/- ##
=========================================
Coverage 88.81% 88.81%
Complexity 49 49
=========================================
Files 7 7
Lines 161 161
Branches 7 7
=========================================
Hits 143 143
Misses 17 17
Partials 1 1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| maven-version: 3.9.6 | ||
| - name: 'Build' | ||
| run: | | ||
| mvn --fail-at-end --batch-mode --no-transfer-progress clean verify No newline at end of file |
There was a problem hiding this comment.
No need to invoke clean after a fresh checkout
| with: | ||
| distribution: 'temurin' | ||
| java-version: '17' | ||
| - uses: stCarolas/setup-maven@v5 |
There was a problem hiding this comment.
Prefer the use of the Maven wrapper and set it up in the project instead
| runs-on: windows-latest | ||
| steps: | ||
| - uses: actions/checkout@v4 | ||
| - uses: actions/cache@v4 |
There was a problem hiding this comment.
use cache: maven setting in actions/setup-java instead
| linux-build: | ||
| name: "JDK 21 Eclipse Temurin Linux" | ||
| runs-on: ubuntu-latest | ||
| container: "maven:3.9.6-eclipse-temurin-21" |
There was a problem hiding this comment.
Why would a custom container be needed? Isn't the default option enough?
Also, removing this container and using a run matrix will remove duplication for linux and windows runs
2 participants
No description provided.