Skip to content

There are a couple of ooooold pull requests for this library. How can these get merged into the master? #32

Description

@PKeller34

I use the SX1509 Qwiic adapter and found a compile time issue in the .cpp a couple years ago. I posted it here, hacked the trivial fix in my local copy way back then and promptly forgot about it. Just now I was compiling on a new machine with the latest library and PRESTO! the same error. Someone fixed it and issued a Pull request a couple years ago but it remains un-merged.

There is one other pull request outstanding with unrelated changes, github says all are able to be merged cleanly.

What would need to be done to get this merged in? Surely this is a question based on ignorance, yet I am ignorant.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions