readline: fetch patches via ftpmirror.gnu.org instead of ftp.gnu.org - #6261
Open
georghammerl wants to merge 1 commit into
Open
readline: fetch patches via ftpmirror.gnu.org instead of ftp.gnu.org#6261georghammerl wants to merge 1 commit into
georghammerl wants to merge 1 commit into
Conversation
spackbot-triage
Bot
added
the
update-package
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ftp.gnu.org intermittently times out for readline's per-version patches (e.g. readline83-002), and Spack's own source-cache mirror doesn't have every patch cached either, causing hard failures in CI and on multiple independent machines.
This PR switches all readline patch URLs to ftpmirror.gnu.org (GNU's mirror-redirector), consistent with how GNUMirrorPackage already fetches the main tarball. Resolves the existing '# TODO: patches below are not managed by the GNUMirrorPackage base class' comment's underlying reliability gap.
Assisted-by: Claude Sonnet 5