add recipe for pre-commit-hooks - #6249
Open
claireguilbaud wants to merge 5 commits into
Open
Conversation
spackbot-triage
Bot
added
new-package
Contributor
Author
|
@spackbot fix style |
|
Let me see if I can fix that for you! |
|
I was able to run spack style --fixrepos/spack_repo/builtin/packages/py_pre_commit_hooks/package.py
�[1;34m==> �[0mrunning ruff format
1 file reformatted
�[1;34m==> �[0mrunning ruff check
All checks passed!
�[1;34m==> �[0mstyle checks passed
I've updated the branch with style fixes. |
cmelone
requested changes
Aug 28, 2026
| version("4.0.1", sha256="25c039a33c77aebcc1500df93125388ed4b96444c39766c42721812a96e44093") | ||
| version("4.0.0", sha256="2ca6da2636b8d6f3afc9f0e6fe7cf36607ae0f116eb4b0f12f76d52a87336c7d") | ||
|
|
||
| # Dépendances Python minimales |
Member
There was a problem hiding this comment.
would you mind changing the comments to english? 🙂
cmelone
requested changes
Aug 28, 2026
cmelone
left a comment
cmelone
left a comment
Member
There was a problem hiding this comment.
please update the dependency constraints according to the values found in https://github.com/pre-commit/pre-commit-hooks/blob/3e8a8703264a2f4a69428a0aa4dcb512790b2c8c/setup.cfg#L18-L23
|
|
||
| # Dépendances Python minimales | ||
| depends_on("py-setuptools", type="build") | ||
| depends_on("py-pyyaml", type=("build", "run")) |
Member
There was a problem hiding this comment.
what's the source of the pyyaml dependency? according to the changelog, it was removed a while ago
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
add recipe for python package
pre-commit-hooks