Make noop jobs timeout faster - #6187
Merged
kwryankrattiger merged 1 commit intoAug 24, 2026
Merged
Conversation
These are not required to pass and do nothing, set a minimal timeout. Signed-off-by: Ryan Krattiger <ryan.krattiger@kitware.com>
bernhardkaindl
approved these changes
Aug 21, 2026
zackgalbreath
approved these changes
Aug 24, 2026
kwryankrattiger
pushed a commit
to spack/spack
that referenced
this pull request
Aug 24, 2026
This fixes GitLab job failures, such as [this one](https://gitlab.spack.io/spack/spack-packages/-/jobs/24099711), that have recently started happening after spack/spack-packages#6187 shortened the timeout for noop jobs. In practice, what spack/spack-packages#6187 did was make it so the vast majority of noop jobs will now fail immediately after starting, since it usually takes more than 1 second for one of these jobs to complete. This is fine for other noop jobs like `no-specs-to-rebuild`, because [they set `allow_failure: true`](https://github.com/spack/spack/blob/c3b3001ddc13b607cd1e36ad81c81c0453d6814d/lib/spack/spack/ci/gitlab.py#L454-L456). The `wait-for-build-jobs` job does not currently set `allow_failure`, so a timeout for that job causes the entire pipeline to be incorrectly marked as failed. Signed-off-by: Mike VanDenburgh <michael.vandenburgh@kitware.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These are not required to pass and do nothing, set a minimal timeout.