legion: disable parallel build for +rocm - #6121
Merged
Merged
Conversation
spackbot-triage
Bot
added
the
update-package
spackbot-triage
Bot
requested review from
elliottslaughter,
pmccormick and
rbberger
August 17, 2026 23:17
Member
|
This should be revisited with the upcoming Legion/Realm September releases. |
Contributor
|
Legion master has already merged the fix. Can we version bound this to 26.06 and earlier? |
Member
Author
I've updated the constraint so that it only disables parallel builds for |
bernhardkaindl
previously approved these changes
Aug 18, 2026
bernhardkaindl
left a comment
bernhardkaindl
left a comment
Contributor
There was a problem hiding this comment.
PS: I see legion is used in CI, but I don't see that +rocm is enabled, so I think it should not change CI duration:
git grep '\<legion\>' .ci/
.ci/gitlab/configs/linux/ci.yaml: - legion
grep rocm .ci/gitlab/configs/linux/ci.yaml
bernhardkaindl
force-pushed
the
legion-rocm-disable-parallel
branch
from
August 18, 2026 16:18
ee2746d to
7d67fcd
Compare
bernhardkaindl
approved these changes
Aug 18, 2026
bernhardkaindl
left a comment
bernhardkaindl
left a comment
Contributor
There was a problem hiding this comment.
@alalazo I un-pushed my accidential push, but now it needs another approver to merge.
rbberger
approved these changes
Aug 19, 2026
Member
|
@spackbot run pipeline |
|
I've started that pipeline for you! |
rbberger
changed the title
legion+rocm+rocm
rbberger
enabled auto-merge (squash)
August 19, 2026 03:27
rbberger
approved these changes
Aug 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extract legion changes for rocm build from #4411
I noticed a problem with an intermittent build error (some sort of race condition) in CI when building
legion+rocmin #4411