Skip to content

Py-torch 2.9, 2.11 and ci build on rocm - #4577

Merged
kwryankrattiger merged 31 commits into
spack:developfrom
renjithravindrankannath:py-torch-2.9-2.11-rocm
Aug 25, 2026
Merged

Py-torch 2.9, 2.11 and ci build on rocm#4577
kwryankrattiger merged 31 commits into
spack:developfrom
renjithravindrankannath:py-torch-2.9-2.11-rocm

Conversation

@renjithravindrankannath

@renjithravindrankannath renjithravindrankannath commented Apr 29, 2026

Copy link
Copy Markdown
Contributor
  • Add PyTorch versions 2.9 and 2.11 with ROCm support
  • Update PyTorch ecosystem packages: torchvision, torchaudio, torch-geometric, lightning, kornia, gpytorch, botorch
  • Add HipBLASLt library for AMD GPU linear algebra operations
  • Update CI configuration with 12-hour timeout for ROCm builds
  • Include patches to fix duplicate symbol errors and build failures on ROCm

@spackbot-triage spackbot-triage Bot added python dependencies Modifications with a `depends_on()` directive update-package Modifications to packages in the repository conflicts Modifications with a `conflicts()` directive ci Related to CI/CD workflows and pipelines labels Apr 29, 2026
@spackbot-triage
spackbot-triage Bot requested review from afzpatel and srekolam April 29, 2026 18:06
@spackbot-triage
spackbot-triage Bot requested a review from adamjstewart April 29, 2026 18:26
@renjithravindrankannath

This comment was marked as outdated.

@spackbot-app

This comment was marked as outdated.

@adamjstewart

adamjstewart commented May 2, 2026

Copy link
Copy Markdown
Member

Is this a duplicate of #3630 and #1582? Should we close these?

@renjithravindrankannath

Copy link
Copy Markdown
Contributor Author

Is this a duplicate of #3630 and #1582? Should we close these?

Yes. I closed #3630 now. It got some old unwanted commit in the history when I merged the develop branch.

@renjithravindrankannath

This comment was marked as outdated.

@spackbot-app

This comment was marked as resolved.

@renjithravindrankannath
renjithravindrankannath force-pushed the py-torch-2.9-2.11-rocm branch 3 times, most recently from 7812c5f to e17959d Compare June 25, 2026 07:03
@spackbot-triage spackbot-triage Bot added the new-variant Modifications to packages' `variant()` directives label Jun 25, 2026
@renjithravindrankannath

This comment was marked as outdated.

@spackbot-app

This comment was marked as outdated.

@spackbot-app

This comment was marked as outdated.

@renjithravindrankannath

Copy link
Copy Markdown
Contributor Author

@spackbot rerun pipeline

@spackbot-app

spackbot-app Bot commented Aug 12, 2026

Copy link
Copy Markdown

I've started that pipeline for you!

@renjithravindrankannath

Copy link
Copy Markdown
Contributor Author

@spackbot rerun pipeline

@spackbot-app

spackbot-app Bot commented Aug 13, 2026

Copy link
Copy Markdown

I've started that pipeline for you!

@renjithravindrankannath

This comment was marked as outdated.

@spackbot-app

This comment was marked as outdated.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Enables broader PyTorch ROCm builds in the ML stack and addresses related build/runtime issues.

Changes:

  • Enables ROCm Torch ecosystem and XGBoost stack builds.
  • Updates PyTorch ROCm dependencies, paths, and AOTriton integration.
  • Adds a torchvision ROCm patch and extends CI timeout.

Reviewed changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
stacks/ml-linux-x86_64/spack.yaml Enables ROCm ML specifications.
repos/spack_repo/builtin/packages/py_torchvision/torchvision-0.26.0-rocm-vision-duplicate-symbol.patch Avoids duplicate ROCm symbols.
repos/spack_repo/builtin/packages/py_torchvision/package.py Applies patch and supplies ROCm includes.
repos/spack_repo/builtin/packages/py_torch/PR152569-Update-spack-includes-2.7.patch Adds AOTriton includes.
repos/spack_repo/builtin/packages/py_torch/PR152569-Update-spack-includes-2.5.patch Adds AOTriton includes.
repos/spack_repo/builtin/packages/py_torch/package.py Updates ROCm constraints and environments.
.ci/gitlab/configs/linux/ci.yaml Extends build timeout to 12 hours.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread repos/spack_repo/builtin/packages/py_torch/package.py Outdated
Comment thread repos/spack_repo/builtin/packages/py_torch/package.py
@renjithravindrankannath

Copy link
Copy Markdown
Contributor Author

@spackbot fix style

@spackbot-app

spackbot-app Bot commented Aug 20, 2026

Copy link
Copy Markdown

Let me see if I can fix that for you!

@spackbot-app

spackbot-app Bot commented Aug 20, 2026

Copy link
Copy Markdown

I was able to run spack style --fix for you!

spack style --fix
repos/spack_repo/builtin/packages/py_torch/package.py
repos/spack_repo/builtin/packages/py_torchvision/package.py
�[1;34m==> �[0mrunning ruff format
1 file reformatted, 1 file left unchanged
�[1;34m==> �[0mrunning ruff check
All checks passed!
�[1;34m==> �[0mstyle checks passed
Keep in mind that I cannot fix your flake8 or mypy errors, so if you have any you'll need to fix them and update the pull request. If I was able to push to your branch, if you make further changes you will need to pull from your updated branch before pushing again.

I've updated the branch with style fixes.

@renjithravindrankannath

Copy link
Copy Markdown
Contributor Author

@spackbot rerun pipeline

@spackbot-app

spackbot-app Bot commented Aug 21, 2026

Copy link
Copy Markdown

I've started that pipeline for you!

@kwryankrattiger kwryankrattiger left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'll have to keep on eye on this pipeline for awhile but it looks to be in a pretty good state.

@kwryankrattiger
kwryankrattiger merged commit c3b260e into spack:develop Aug 25, 2026
33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci Related to CI/CD workflows and pipelines conflicts Modifications with a `conflicts()` directive dependencies Modifications with a `depends_on()` directive new-variant Modifications to packages' `variant()` directives patch Modifications to packages' sets of defined patches python update-package Modifications to packages in the repository

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants