Py-torch 2.9, 2.11 and ci build on rocm - #4577
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as resolved.
This comment was marked as resolved.
7812c5f to
e17959d
Compare
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
|
@spackbot rerun pipeline |
|
I've started that pipeline for you! |
|
@spackbot rerun pipeline |
|
I've started that pipeline for you! |
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
There was a problem hiding this comment.
Pull request overview
Enables broader PyTorch ROCm builds in the ML stack and addresses related build/runtime issues.
Changes:
- Enables ROCm Torch ecosystem and XGBoost stack builds.
- Updates PyTorch ROCm dependencies, paths, and AOTriton integration.
- Adds a torchvision ROCm patch and extends CI timeout.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
stacks/ml-linux-x86_64/spack.yaml |
Enables ROCm ML specifications. |
repos/spack_repo/builtin/packages/py_torchvision/torchvision-0.26.0-rocm-vision-duplicate-symbol.patch |
Avoids duplicate ROCm symbols. |
repos/spack_repo/builtin/packages/py_torchvision/package.py |
Applies patch and supplies ROCm includes. |
repos/spack_repo/builtin/packages/py_torch/PR152569-Update-spack-includes-2.7.patch |
Adds AOTriton includes. |
repos/spack_repo/builtin/packages/py_torch/PR152569-Update-spack-includes-2.5.patch |
Adds AOTriton includes. |
repos/spack_repo/builtin/packages/py_torch/package.py |
Updates ROCm constraints and environments. |
.ci/gitlab/configs/linux/ci.yaml |
Extends build timeout to 12 hours. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
efa580e to
a4a6d31
Compare
|
@spackbot fix style |
|
Let me see if I can fix that for you! |
|
I was able to run spack style --fixrepos/spack_repo/builtin/packages/py_torch/package.py
repos/spack_repo/builtin/packages/py_torchvision/package.py
�[1;34m==> �[0mrunning ruff format
1 file reformatted, 1 file left unchanged
�[1;34m==> �[0mrunning ruff check
All checks passed!
�[1;34m==> �[0mstyle checks passed
I've updated the branch with style fixes. |
|
@spackbot rerun pipeline |
|
I've started that pipeline for you! |
kwryankrattiger
left a comment
There was a problem hiding this comment.
We'll have to keep on eye on this pipeline for awhile but it looks to be in a pretty good state.
Uh oh!
There was an error while loading. Please reload this page.